fix: Enable users to upgrade a batch source into a push source (#3213)

Signed-off-by: Danny Chiao <[email protected]>

Signed-off-by: Danny Chiao <[email protected]>

Makefile

@@ -63,11 +63,9 @@ benchmark-python-local:
 	FEAST_USAGE=False IS_TEST=True FEAST_IS_LOCAL_TEST=True python -m pytest --integration --benchmark  --benchmark-autosave --benchmark-save-data sdk/python/tests
 
 test-python:
-	@(docker info > /dev/null 2>&1 && \
-		FEAST_USAGE=False \
-		IS_TEST=True \
-		python -m pytest -n 8 sdk/python/tests \
-	) || echo "This script uses Docker, and it isn't running - please start the Docker Daemon and try again!";
+	FEAST_USAGE=False \
+	IS_TEST=True \
+	python -m pytest -n 8 sdk/python/tests \
 
 test-python-integration:
 	FEAST_USAGE=False IS_TEST=True python -m pytest -n 8 --integration sdk/python/tests

sdk/python/feast/data_source.py

@@ -760,7 +760,7 @@ def __init__(
 
     def __eq__(self, other):
         if not isinstance(other, PushSource):
-            raise TypeError("Comparisons should only involve PushSource class objects.")
+            return False
 
         if not super().__eq__(other):
             return False

sdk/python/tests/unit/diff/test_registry_diff.py

@@ -1,6 +1,6 @@
 import pandas as pd
 
-from feast import Field
+from feast import Field, PushSource
 from feast.diff.registry_diff import (
     diff_registry_objects,
     tag_objects_for_keep_delete_update_add,
@@ -145,3 +145,27 @@ def post_changed(inputs: pd.DataFrame) -> pd.DataFrame:
             feast_object_diffs.feast_object_property_diffs[2].property_name
             == "user_defined_function.body_text"
         )
+
+
+def test_diff_registry_objects_batch_to_push_source(simple_dataset_1):
+    with prep_file_source(df=simple_dataset_1, timestamp_field="ts_1") as file_source:
+        entity = Entity(name="id", join_keys=["id"])
+        pre_changed = FeatureView(
+            name="fv2",
+            entities=[entity],
+            source=file_source,
+        )
+        post_changed = FeatureView(
+            name="fv2",
+            entities=[entity],
+            source=PushSource(name="push_source", batch_source=file_source),
+        )
+
+        feast_object_diffs = diff_registry_objects(
+            pre_changed, post_changed, "feature view"
+        )
+        assert len(feast_object_diffs.feast_object_property_diffs) == 1
+        assert (
+            feast_object_diffs.feast_object_property_diffs[0].property_name
+            == "stream_source"
+        )