fix: Update snowflake materialization messages #3230

sfc-gh-madkins · 2022-09-17T02:56:36Z

Signed-off-by: Miles [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

codecov-commenter · 2022-09-17T03:06:13Z

Codecov Report

Base: 67.31% // Head: 58.25% // Decreases project coverage by -9.05% ⚠️

Coverage data is based on head (8afffc2) compared to base (769c318).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3230      +/-   ##
==========================================
- Coverage   67.31%   58.25%   -9.06%     
==========================================
  Files         179      210      +31     
  Lines       16278    17704    +1426     
==========================================
- Hits        10958    10314     -644     
- Misses       5320     7390    +2070

Flag	Coverage Δ
integrationtests	`?`
unittests	`58.25% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...sts/integration/registration/test_universal_cli.py	`20.20% <0.00%> (-79.80%)`	⬇️
...ts/integration/offline_store/test_offline_write.py	`26.08% <0.00%> (-73.92%)`	⬇️
...fline_store/test_universal_historical_retrieval.py	`28.75% <0.00%> (-71.25%)`	⬇️
...ests/integration/e2e/test_python_feature_server.py	`29.50% <0.00%> (-70.50%)`	⬇️
...dk/python/tests/integration/e2e/test_validation.py	`27.55% <0.00%> (-69.30%)`	⬇️
...s/integration/registration/test_universal_types.py	`32.25% <0.00%> (-67.75%)`	⬇️
sdk/python/feast/infra/online_stores/redis.py	`28.39% <0.00%> (-66.58%)`	⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py	`33.87% <0.00%> (-66.13%)`	⬇️
sdk/python/tests/data/data_creator.py	`34.78% <0.00%> (-65.22%)`	⬇️
...n/tests/integration/registration/test_inference.py	`35.71% <0.00%> (-64.29%)`	⬇️
... and 167 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

felixwang9817

/lgtm

feast-ci-bot · 2022-09-20T02:41:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, sfc-gh-madkins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

feast-ci-bot · 2022-09-21T14:04:10Z

New changes are detected. LGTM label has been removed.

Signed-off-by: miles.adkins <[email protected]>

Signed-off-by: miles.adkins <[email protected]> Signed-off-by: miles.adkins <[email protected]>

## [0.25.1](v0.25.0...v0.25.1) (2022-09-30) ### Bug Fixes * Add `X-Trino-Extra-Credential` header and remove user override ([#3246](#3246)) ([f38506c](f38506c)) * Add postgres to the feature server Dockerfile to fix helm chart flow ([#3261](#3261)) ([a2cb995](a2cb995)) * Add stream feature view in the Web UI ([#3257](#3257)) ([47d4c93](47d4c93)) * Build dockerfile correctly ([#3239](#3239)) ([a2dc0d0](a2dc0d0)) * Configuration to stop coercion of tz for entity_df ([#3255](#3255)) ([fdc8d67](fdc8d67)) * Enable users to upgrade a batch source into a push source ([#3213](#3213)) ([8f2fb58](8f2fb58)) * Return 422 on bad push source name ([#3214](#3214)) ([8abbcd9](8abbcd9)) * Stream feature view not shown in the UI ([#3251](#3251)) ([55e28e2](55e28e2)) * Update snowflake materialization messages ([#3230](#3230)) ([a63d440](a63d440)) * Use configured user in env var instead of "user" for Trino ([#3254](#3254)) ([e7ed3d5](e7ed3d5))

## [0.25.1](feast-dev/feast@v0.25.0...v0.25.1) (2022-09-30) ### Bug Fixes * Add `X-Trino-Extra-Credential` header and remove user override ([feast-dev#3246](feast-dev#3246)) ([f38506c](feast-dev@f38506c)) * Add postgres to the feature server Dockerfile to fix helm chart flow ([feast-dev#3261](feast-dev#3261)) ([a2cb995](feast-dev@a2cb995)) * Add stream feature view in the Web UI ([feast-dev#3257](feast-dev#3257)) ([47d4c93](feast-dev@47d4c93)) * Build dockerfile correctly ([feast-dev#3239](feast-dev#3239)) ([a2dc0d0](feast-dev@a2dc0d0)) * Configuration to stop coercion of tz for entity_df ([feast-dev#3255](feast-dev#3255)) ([fdc8d67](feast-dev@fdc8d67)) * Enable users to upgrade a batch source into a push source ([feast-dev#3213](feast-dev#3213)) ([8f2fb58](feast-dev@8f2fb58)) * Return 422 on bad push source name ([feast-dev#3214](feast-dev#3214)) ([8abbcd9](feast-dev@8abbcd9)) * Stream feature view not shown in the UI ([feast-dev#3251](feast-dev#3251)) ([55e28e2](feast-dev@55e28e2)) * Update snowflake materialization messages ([feast-dev#3230](feast-dev#3230)) ([a63d440](feast-dev@a63d440)) * Use configured user in env var instead of "user" for Trino ([feast-dev#3254](feast-dev#3254)) ([e7ed3d5](feast-dev@e7ed3d5))

# [0.26.0](v0.25.0...v0.26.0) (2022-10-06) ### Bug Fixes * Add `X-Trino-Extra-Credential` header and remove user override ([#3246](#3246)) ([164e666](164e666)) * Add postgres to the feature server Dockerfile to fix helm chart flow ([#3261](#3261)) ([6f6cbb7](6f6cbb7)) * Add stream feature view in the Web UI ([#3257](#3257)) ([1f70b3a](1f70b3a)) * Build dockerfile correctly ([#3239](#3239)) ([a2dc0d0](a2dc0d0)) * Configuration to stop coercion of tz for entity_df ([#3255](#3255)) ([97b7ab9](97b7ab9)) * Enable users to upgrade a batch source into a push source ([#3213](#3213)) ([1b312fb](1b312fb)) * Fix docker image for feature-server ([#3272](#3272)) ([eff01d1](eff01d1)) * Fix Feast UI release process to update the feast-ui package ([#3267](#3267)) ([a9d48d0](a9d48d0)) * Return 422 on bad push source name ([#3214](#3214)) ([b851e01](b851e01)) * Stream feature view meta undefined created_timestamp issue ([#3266](#3266)) ([12e1a8f](12e1a8f)) * Stream feature view not shown in the UI ([#3251](#3251)) ([e713dda](e713dda)) * Udf in stream feature view UI shows pickled data ([#3268](#3268)) ([0728117](0728117)) * Update snowflake materialization messages ([#3230](#3230)) ([a63d440](a63d440)) * Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([#3271](#3271)) ([b9b9c54](b9b9c54)) * Use configured user in env var instead of "user" for Trino ([#3254](#3254)) ([532d8a1](532d8a1)) ### Features * Add mysql as online store ([#3190](#3190)) ([cb8db84](cb8db84)) * Add possibility to define feature_store.yaml path with env variable ([#3231](#3231)) ([95fdb19](95fdb19)) * Add request_timeout setting for cassandra online store adapter ([#3256](#3256)) ([da20757](da20757)) * Add tag description in Field in the Feast UI ([#3258](#3258)) ([086f279](086f279)) * Adding billing_project_id in BigQueryOfflineStoreConfig ([#3253](#3253)) ([f80f05f](f80f05f)) * BigTable online store ([#3140](#3140)) ([6bc91c2](6bc91c2)), closes [/github.com/spulec/moto/blob/master/CHANGELOG.md#400](https://github.com//github.com/spulec/moto/blob/master/CHANGELOG.md/issues/400) * Filter subset features in postgres [#3174](#3174) ([#3203](#3203)) ([b48d36b](b48d36b))

# [0.26.0](feast-dev/feast@v0.25.0...v0.26.0) (2022-10-06) ### Bug Fixes * Add `X-Trino-Extra-Credential` header and remove user override ([feast-dev#3246](feast-dev#3246)) ([164e666](feast-dev@164e666)) * Add postgres to the feature server Dockerfile to fix helm chart flow ([feast-dev#3261](feast-dev#3261)) ([6f6cbb7](feast-dev@6f6cbb7)) * Add stream feature view in the Web UI ([feast-dev#3257](feast-dev#3257)) ([1f70b3a](feast-dev@1f70b3a)) * Build dockerfile correctly ([feast-dev#3239](feast-dev#3239)) ([a2dc0d0](feast-dev@a2dc0d0)) * Configuration to stop coercion of tz for entity_df ([feast-dev#3255](feast-dev#3255)) ([97b7ab9](feast-dev@97b7ab9)) * Enable users to upgrade a batch source into a push source ([feast-dev#3213](feast-dev#3213)) ([1b312fb](feast-dev@1b312fb)) * Fix docker image for feature-server ([feast-dev#3272](feast-dev#3272)) ([eff01d1](feast-dev@eff01d1)) * Fix Feast UI release process to update the feast-ui package ([feast-dev#3267](feast-dev#3267)) ([a9d48d0](feast-dev@a9d48d0)) * Return 422 on bad push source name ([feast-dev#3214](feast-dev#3214)) ([b851e01](feast-dev@b851e01)) * Stream feature view meta undefined created_timestamp issue ([feast-dev#3266](feast-dev#3266)) ([12e1a8f](feast-dev@12e1a8f)) * Stream feature view not shown in the UI ([feast-dev#3251](feast-dev#3251)) ([e713dda](feast-dev@e713dda)) * Udf in stream feature view UI shows pickled data ([feast-dev#3268](feast-dev#3268)) ([0728117](feast-dev@0728117)) * Update snowflake materialization messages ([feast-dev#3230](feast-dev#3230)) ([a63d440](feast-dev@a63d440)) * Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([feast-dev#3271](feast-dev#3271)) ([b9b9c54](feast-dev@b9b9c54)) * Use configured user in env var instead of "user" for Trino ([feast-dev#3254](feast-dev#3254)) ([532d8a1](feast-dev@532d8a1)) ### Features * Add mysql as online store ([feast-dev#3190](feast-dev#3190)) ([cb8db84](feast-dev@cb8db84)) * Add possibility to define feature_store.yaml path with env variable ([feast-dev#3231](feast-dev#3231)) ([95fdb19](feast-dev@95fdb19)) * Add request_timeout setting for cassandra online store adapter ([feast-dev#3256](feast-dev#3256)) ([da20757](feast-dev@da20757)) * Add tag description in Field in the Feast UI ([feast-dev#3258](feast-dev#3258)) ([086f279](feast-dev@086f279)) * Adding billing_project_id in BigQueryOfflineStoreConfig ([feast-dev#3253](feast-dev#3253)) ([f80f05f](feast-dev@f80f05f)) * BigTable online store ([feast-dev#3140](feast-dev#3140)) ([6bc91c2](feast-dev@6bc91c2)), closes [/github.com/spulec/moto/blob/master/CHANGELOG.md#400](https://github.com//github.com/spulec/moto/blob/master/CHANGELOG.md/issues/400) * Filter subset features in postgres [feast-dev#3174](feast-dev#3174) ([feast-dev#3203](feast-dev#3203)) ([b48d36b](feast-dev@b48d36b))

sfc-gh-madkins added the ok-to-test label Sep 17, 2022

feast-ci-bot added the size/S label Sep 17, 2022

sfc-gh-madkins enabled auto-merge (squash) September 20, 2022 02:15

sfc-gh-madkins force-pushed the snowengine branch from a3b6ffa to 55efd1b Compare September 20, 2022 02:17

sfc-gh-madkins changed the title ~~fix: update snowflake materialization messages~~ fix: Update snowflake materialization messages Sep 20, 2022

sfc-gh-madkins force-pushed the snowengine branch 2 times, most recently from 0568d7b to ce4122a Compare September 20, 2022 02:29

felixwang9817 approved these changes Sep 20, 2022

View reviewed changes

feast-ci-bot assigned felixwang9817 Sep 20, 2022

feast-ci-bot added the lgtm label Sep 20, 2022

feast-ci-bot added the approved label Sep 20, 2022

sfc-gh-madkins disabled auto-merge September 20, 2022 16:28

sfc-gh-madkins enabled auto-merge (squash) September 20, 2022 16:29

sfc-gh-madkins force-pushed the snowengine branch from ce4122a to 42d0c58 Compare September 21, 2022 14:04

feast-ci-bot removed the lgtm label Sep 21, 2022

fix: Update snowpark materialization messages

8afffc2

Signed-off-by: miles.adkins <[email protected]>

sfc-gh-madkins force-pushed the snowengine branch from 42d0c58 to 8afffc2 Compare September 21, 2022 15:29

sfc-gh-madkins merged commit a63d440 into feast-dev:master Sep 21, 2022

vmallya-123 pushed a commit to vmallya-123/feast that referenced this pull request Sep 27, 2022

fix: Update snowflake materialization messages (feast-dev#3230)

3069e23

Signed-off-by: miles.adkins <[email protected]> Signed-off-by: miles.adkins <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Update snowflake materialization messages #3230

fix: Update snowflake materialization messages #3230

sfc-gh-madkins commented Sep 17, 2022

codecov-commenter commented Sep 17, 2022 •

edited

Loading

felixwang9817 left a comment

feast-ci-bot commented Sep 20, 2022

feast-ci-bot commented Sep 21, 2022

fix: Update snowflake materialization messages #3230

fix: Update snowflake materialization messages #3230

Conversation

sfc-gh-madkins commented Sep 17, 2022

codecov-commenter commented Sep 17, 2022 • edited Loading

Codecov Report

felixwang9817 left a comment

Choose a reason for hiding this comment

feast-ci-bot commented Sep 20, 2022

feast-ci-bot commented Sep 21, 2022

codecov-commenter commented Sep 17, 2022 •

edited

Loading