Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker compose for Feast #272

Closed
woop opened this issue Oct 24, 2019 · 4 comments
Closed

Docker compose for Feast #272

woop opened this issue Oct 24, 2019 · 4 comments
Labels
area/infra good first issue Good for newcomers kind/feature New feature or request

Comments

@woop
Copy link
Member

woop commented Oct 24, 2019

We've had requests for a Docker Compose script to initialize a Feast deployment. This would make it easier for Non-Kube based deployment, especially during quickstarts or tests.

The proposed use case here is for a single docker-compose up to bring up a running Feast deployment. It should minimally include

  • Redis
  • Kafka
  • Feast Core
  • Feast Core DB
  • Feast Serving

The default configuration can be used for these components. The existing Helm installation can be used for reference.
@woop woop added kind/feature New feature or request good first issue Good for newcomers area/infra labels Oct 24, 2019
@khorshuheng
Copy link
Collaborator

As discussed, i will start working on this.

@ches
Copy link
Member

ches commented Oct 30, 2019

We have this done, although it is probably more than what many people developing on the project would want all the time because it includes containers for dev with Cassandra and Hive as well. We could structure a base docker-compose.yml with the components given above, and an extra one or two for extending the base if developing/testing for those storage options.

@woop
Copy link
Member Author

woop commented Oct 30, 2019

We have this done, although it is probably more than what many people developing on the project would want all the time because it includes containers for dev with Cassandra and Hive as well. We could structure a base docker-compose.yml with the components given above, and an extra one or two for extending the base if developing/testing for those storage options.

Wow that is great news!

I think your approach makes sense. The primary group I would like to target with Docker Compose are end users who aren't familiar with Minikube or Kubernetes. Would be great if we could get them up and running and testing the system. Developers would also benefit from the availability of this.

I don't really have strong feelings on which stores to start with, but having an opinionated default with some options would make sense.

This was referenced Nov 11, 2019
Closed
Merged
kaihendry pushed a commit to kaihendry/feast that referenced this issue Nov 19, 2019
Added docker-compose file for Feast
7255d30 
Closes feast-dev#272

Tested by:

    $ grpc_cli ls localhost:6565
    grpc.health.v1.Health
    grpc.reflection.v1alpha.ServerReflection
    feast.core.CoreService

    $ grpc_cli ls localhost:6566
    grpc.health.v1.Health
    grpc.reflection.v1alpha.ServerReflection
    feast.serving.ServingService
@khorshuheng khorshuheng mentioned this issue Nov 26, 2019
Merged
@woop
Copy link
Member Author

woop commented Dec 17, 2019

This is resolved in #328

@woop woop closed this as completed Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/infra good first issue Good for newcomers kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ches @woop @khorshuheng