fix: Pin dependencies to nearest major version #2647

kevjumba · 2022-05-06T01:10:08Z

What this PR does / why we need it:
Pins dependencies to major version range to prevent breaking changes with newest version.

Which issue(s) this PR fixes:

Fixes #2557

codecov-commenter · 2022-05-06T01:16:26Z

Codecov Report

Merging #2647 (a1b7e77) into master (30e0bf3) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2647      +/-   ##
==========================================
- Coverage   80.65%   80.61%   -0.04%     
==========================================
  Files         165      165              
  Lines       13732    14226     +494     
==========================================
+ Hits        11075    11469     +394     
- Misses       2657     2757     +100

Flag	Coverage Δ
integrationtests	`71.69% <ø> (+0.05%)`	⬆️
unittests	`58.68% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
setup.py	`0.00% <ø> (ø)`
...n/tests/integration/registration/test_inference.py	`73.36% <0.00%> (-26.64%)`	⬇️
sdk/python/tests/utils/online_read_write_test.py	`93.54% <0.00%> (-6.46%)`	⬇️
sdk/python/feast/feature_service.py	`87.50% <0.00%> (-5.45%)`	⬇️
.../integration/online_store/test_online_retrieval.py	`96.84% <0.00%> (-3.16%)`	⬇️
...ython/feast/embedded_go/online_features_service.py	`89.65% <0.00%> (-0.87%)`	⬇️
sdk/python/feast/type_map.py	`63.58% <0.00%> (+0.51%)`	⬆️
sdk/python/feast/feature_store.py	`90.15% <0.00%> (+0.90%)`	⬆️
sdk/python/feast/feature_logging.py	`91.40% <0.00%> (+2.51%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30e0bf3...a1b7e77. Read the comment docs.

achals

/lgtm

feast-ci-bot · 2022-05-06T17:54:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [achals,kevjumba]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

achals · 2022-05-06T23:26:46Z

sdk/python/requirements/py3.10-requirements.txt

    # via
    #   feast (setup.py)
    #   pandavro
 fsspec==2022.3.0
    # via dask
-google-api-core==2.7.2


should we be concerned that we went down a whole major version here? Is it even still supported?

Hm this was specific to 3.10. Every other version has a major version of 1.

achals · 2022-05-06T23:26:55Z

sdk/python/requirements/py3.10-requirements.txt

    # via feast (setup.py)
-google-auth==2.6.5


achals · 2022-05-06T23:32:22Z

setup.py

-    "grpcio-reflection>=1.34.0",
-    "Jinja2>=2.0.0",
+    "fastavro>=1.1.0,<2",
+    "google-api-core>=1.23.0,<2",


We should probably do

Suggested change

"google-api-core>=1.23.0,<2",

"google-api-core>=2,<3",

Yup I checked the version against 3.8 and there weren't any major version bumps. I think it's only 3.10 that has a version bump. I can bump google-api-core restrictions up to 3, aka >=1, <3, this allows us to generate for both 3.10 and others.

Sure, that's fine by me.

achals · 2022-05-06T23:32:33Z

setup.py

-    "Jinja2>=2.0.0",
+    "fastavro>=1.1.0,<2",
+    "google-api-core>=1.23.0,<2",
+    "googleapis-common-protos==1.52.*,<2",


This is already newest version (1.52.*)

achals · 2022-05-06T23:34:00Z

setup.py

-    "fastapi>=0.68.0",
-    "uvicorn[standard]>=0.14.0",
+    "fastapi>=0.68.0,<1",
+    "uvicorn[standard]>=0.14.0,<1",
    "proto-plus<1.19.7",
    "tensorflow-metadata>=1.0.0,<2.0.0",
    "dask>=2021.*,<2022.02.0",
 ]

 GCP_REQUIRED = [


All of these should probably have the same version ranges

Signed-off-by: Kevin Zhang <[email protected]>

achals · 2022-05-11T05:39:00Z

/lgtm

# [0.21.0](v0.20.0...v0.21.0) (2022-05-13) ### Bug Fixes * Addresses ZeroDivisionError when materializing file source with same timestamps ([#2551](#2551)) ([1e398d9](1e398d9)) * Asynchronously refresh registry for the feast ui command ([#2672](#2672)) ([1b09ca2](1b09ca2)) * Build platform specific python packages with ci-build-wheel ([#2555](#2555)) ([b10a4cf](b10a4cf)) * Delete data sources from registry when using the diffing logic ([#2669](#2669)) ([fc00ca8](fc00ca8)) * Enforce kw args featureservice ([#2575](#2575)) ([160d7b7](160d7b7)) * Enforce kw args in datasources ([#2567](#2567)) ([0b7ec53](0b7ec53)) * Feature logging to Redshift is broken ([#2655](#2655)) ([479cd51](479cd51)) * Feature service to templates ([#2649](#2649)) ([1e02066](1e02066)) * Feature with timestamp type is incorrectly interpreted by Go FS ([#2588](#2588)) ([e3d9588](e3d9588)) * Fix `__hash__` methods ([#2556](#2556)) ([ebb7dfe](ebb7dfe)) * Fix AWS bootstrap template ([#2604](#2604)) ([c94a69c](c94a69c)) * Fix broken proto conversion methods for data sources ([#2603](#2603)) ([00ed65a](00ed65a)) * Fix case where on demand feature view tab is broken if no custom tabs are passed. ([#2682](#2682)) ([01d3568](01d3568)) * Fix DynamoDB fetches when there are entities that are not found ([#2573](#2573)) ([7076fe0](7076fe0)) * Fix Feast UI parser to work with new APIs ([#2668](#2668)) ([8d76751](8d76751)) * Fix java server after odfv update ([#2602](#2602)) ([0ca6297](0ca6297)) * Fix materialization with ttl=0 bug ([#2666](#2666)) ([ab78702](ab78702)) * Fix push sources and add docs / tests pushing via the python feature server ([#2561](#2561)) ([e8e418e](e8e418e)) * Fixed data mapping errors for Snowflake ([#2558](#2558)) ([53c2ce2](53c2ce2)) * Forcing ODFV udfs to be __main__ module and fixing false positive duplicate data source warning ([#2677](#2677)) ([2ce33cd](2ce33cd)) * Include the ui/build directory, and remove package data ([#2681](#2681)) ([0384f5f](0384f5f)) * Infer features for feature services when they depend on feature views without schemas ([#2653](#2653)) ([87c194c](87c194c)) * Pin dependencies to nearest major version ([#2647](#2647)) ([bb72b7c](bb72b7c)) * Pin pip<22.1 to get around breaking change in pip==22.1 ([#2678](#2678)) ([d3e01bc](d3e01bc)) * Punt deprecation warnings and clean up some warnings. ([#2670](#2670)) ([f775d2e](f775d2e)) * Reject undefined features when using `get_historical_features` or `get_online_features` ([#2665](#2665)) ([36849fb](36849fb)) * Remove ci extra from the feature transformation server dockerfile ([#2618](#2618)) ([25613b4](25613b4)) * Remove incorrect call to logging.basicConfig ([#2676](#2676)) ([8cbf51c](8cbf51c)) * Small typo in CLI ([#2578](#2578)) ([f372981](f372981)) * Switch from `join_key` to `join_keys` in tests and docs ([#2580](#2580)) ([d66c931](d66c931)) * Teardown trino container correctly after tests ([#2562](#2562)) ([72f1558](72f1558)) * Update build_go_protos to use a consistent python path ([#2550](#2550)) ([f136f8c](f136f8c)) * Update data source timestamp inference error message to make sense ([#2636](#2636)) ([3eaf6b7](3eaf6b7)) * Update field api to add tag parameter corresponding to labels in Feature. ([#2610](#2610)) ([689d20b](689d20b)) * Update java integration tests and add more logging ([#2637](#2637)) ([10e23b4](10e23b4)) * Update on demand feature view api ([#2587](#2587)) ([38cd7f9](38cd7f9)) * Update RedisCluster to use redis-py official implementation ([#2554](#2554)) ([ce5606f](ce5606f)) * Use cwd when getting module path ([#2577](#2577)) ([b550e59](b550e59)) * Use ParquetDataset for Schema Inference ([#2686](#2686)) ([4f85e3e](4f85e3e)) * Use timestamp type when converting unixtimestamp feature type to arrow ([#2593](#2593)) ([c439611](c439611)) ### Features * Add hbase online store support in feast ([#2590](#2590)) ([c9eda79](c9eda79)) * Adding SSL options for Postgres ([#2644](#2644)) ([0e809c2](0e809c2)) * Allow Feast UI to be spun up with CLI command: feast ui ([#2667](#2667)) ([44ca9f5](44ca9f5)) * Allow to pass secrets and environment variables to transformation service ([#2632](#2632)) ([ffa33ad](ffa33ad)) * CLI command 'feast serve' should start go-based server if flag is enabled ([#2617](#2617)) ([f3ff812](f3ff812)) * Create stream and batch feature view abstractions ([#2559](#2559)) ([d1f76e5](d1f76e5)) * Postgres supported as Registry, Online store, and Offline store ([#2401](#2401)) ([ed2f979](ed2f979)) * Support entity fields in feature view `schema` parameter by dropping them ([#2568](#2568)) ([c8fcc35](c8fcc35)) * Write logged features to an offline store (Python API) ([#2574](#2574)) ([134dc5f](134dc5f)) * Write logged features to Offline Store (Go - Python integration) ([#2621](#2621)) ([ccad832](ccad832)) ### Reverts * Revert "chore: Deprecate value type (#2611)" (#2643) ([4fbdfb1](4fbdfb1)), closes [#2611](#2611) [#2643](#2643)

feast-ci-bot added approved size/L labels May 6, 2022

kevjumba added kind/techdebt ok-to-test and removed size/L labels May 6, 2022

feast-ci-bot added size/L size/XL and removed size/L labels May 6, 2022

kevjumba added ok-to-test and removed ok-to-test labels May 6, 2022

achals approved these changes May 6, 2022

View reviewed changes

feast-ci-bot assigned achals May 6, 2022

feast-ci-bot added lgtm and removed lgtm labels May 6, 2022

achals reviewed May 6, 2022

View reviewed changes

kevjumba force-pushed the pin_dependencies branch from 00b55c8 to fb7780a Compare May 10, 2022 00:02

kevjumba and others added 6 commits May 10, 2022 15:05

fix

9ae20f5

Signed-off-by: Kevin Zhang <[email protected]>

Fix

b094c60

Signed-off-by: Kevin Zhang <[email protected]>

Fix requirements

8ef70db

Signed-off-by: Kevin Zhang <[email protected]>

Fix

90dc635

Signed-off-by: Kevin Zhang <[email protected]>

Fix

8ef7431

Signed-off-by: Kevin Zhang <[email protected]>

Address issues

a1b7e77

Signed-off-by: Kevin Zhang <[email protected]>

achals force-pushed the pin_dependencies branch from fb7780a to a1b7e77 Compare May 10, 2022 22:05

feast-ci-bot added the lgtm label May 11, 2022

achals added ok-to-test and removed ok-to-test labels May 11, 2022

feast-ci-bot merged commit bb72b7c into feast-dev:master May 11, 2022

breno-costa mentioned this pull request Jun 29, 2022

fix: Change numpy version on setup.py and upgrade it to resolve dependabot warning #2887

Merged

felixwang9817 mentioned this pull request Jul 5, 2022

Widen dependencies #2906

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Pin dependencies to nearest major version #2647

fix: Pin dependencies to nearest major version #2647

kevjumba commented May 6, 2022

codecov-commenter commented May 6, 2022 •

edited

Loading

achals left a comment

feast-ci-bot commented May 6, 2022

achals May 6, 2022

kevjumba May 7, 2022

achals May 6, 2022

kevjumba May 7, 2022

achals May 6, 2022

kevjumba May 7, 2022 •

edited

Loading

achals May 9, 2022

achals May 6, 2022

kevjumba May 7, 2022

achals May 9, 2022

achals May 6, 2022

achals commented May 11, 2022

fix: Pin dependencies to nearest major version #2647

fix: Pin dependencies to nearest major version #2647

Conversation

kevjumba commented May 6, 2022

codecov-commenter commented May 6, 2022 • edited Loading

Codecov Report

achals left a comment

Choose a reason for hiding this comment

feast-ci-bot commented May 6, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevjumba May 7, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

achals commented May 11, 2022

codecov-commenter commented May 6, 2022 •

edited

Loading

kevjumba May 7, 2022 •

edited

Loading