Deduplicate storage ids before we fetch them (#68)

feast-dev · Jan 14, 2019 · f675650 · f675650
1 parent 6dc20dc
commit f675650
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/ingestion/src/main/java/feast/ingestion/model/Specs.java b/ingestion/src/main/java/feast/ingestion/model/Specs.java
@@ -19,6 +19,7 @@
 
 import com.google.common.base.Preconditions;
 import com.google.common.collect.Lists;
+import com.google.common.collect.Sets;
 import feast.ingestion.service.SpecService;
 import feast.specs.EntitySpecProto.EntitySpec;
 import feast.specs.FeatureSpecProto.FeatureSpec;
@@ -30,6 +31,7 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
+import java.util.Set;
 import lombok.Builder;
 import lombok.Getter;
 import lombok.ToString;
@@ -63,7 +65,7 @@ public static Specs of(String jobName, ImportSpec importSpec, SpecService specSe
       specsBuilder.featureSpecs(specService.getFeatureSpecs(featureIds));
 
       List<String> entityNames = importSpec.getEntitiesList();
-      List<String> storageIds = Lists.newArrayList();
+      Set<String> storageIds = Sets.newHashSet();
       for (FeatureSpec featureSpec : specsBuilder.featureSpecs.values()) {
         Preconditions.checkArgument(
             entityNames.contains(featureSpec.getEntity()),