fix first party refernces to use kwargs only

Signed-off-by: Achal Shah <[email protected]>
feast-dev · Apr 5, 2022 · f5fc225 · f5fc225
1 parent ea85086
commit f5fc225
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 18 deletions.
diff --git a/sdk/python/feast/data_source.py b/sdk/python/feast/data_source.py
@@ -209,9 +209,11 @@ def __init__(
         """
         if not name:
             warnings.warn(
-                ("Names for data sources need to be supplied. "
-                 "Data sources without names will no tbe supported after Feast 0.23."),
-                UserWarning
+                (
+                    "Names for data sources need to be supplied. "
+                    "Data sources without names will no tbe supported after Feast 0.23."
+                ),
+                UserWarning,
             )
         self.name = name or ""
         self.event_timestamp_column = (
@@ -348,14 +350,14 @@ def __init__(
         owner: Optional[str] = "",
     ):
         super().__init__(
-            name,
-            event_timestamp_column,
-            created_timestamp_column,
-            field_mapping,
-            date_partition_column,
+            event_timestamp_column=event_timestamp_column,
+            created_timestamp_column=created_timestamp_column,
+            field_mapping=field_mapping,
+            date_partition_column=date_partition_column,
             description=description,
             tags=tags,
             owner=owner,
+            name=name,
         )
         self.kafka_options = KafkaOptions(
             bootstrap_servers=bootstrap_servers,
@@ -446,7 +448,7 @@ def __init__(
         owner: Optional[str] = "",
     ):
         """Creates a RequestDataSource object."""
-        super().__init__(name, description=description, tags=tags, owner=owner)
+        super().__init__(name=name, description=description, tags=tags, owner=owner)
         self.schema = schema
 
     def validate(self, config: RepoConfig):
@@ -544,11 +546,11 @@ def __init__(
         owner: Optional[str] = "",
     ):
         super().__init__(
-            name,
-            event_timestamp_column,
-            created_timestamp_column,
-            field_mapping,
-            date_partition_column,
+            name=name,
+            event_timestamp_column=event_timestamp_column,
+            created_timestamp_column=created_timestamp_column,
+            field_mapping=field_mapping,
+            date_partition_column=date_partition_column,
             description=description,
             tags=tags,
             owner=owner,
@@ -628,7 +630,7 @@ def __init__(
             owner (optional): The owner of the data source, typically the email of the primary
                 maintainer.
         """
-        super().__init__(name, description=description, tags=tags, owner=owner)
+        super().__init__(name=name, description=description, tags=tags, owner=owner)
         self.schema = schema
         self.batch_source = batch_source
         if not self.batch_source:

diff --git a/sdk/python/feast/infra/offline_stores/bigquery_source.py b/sdk/python/feast/infra/offline_stores/bigquery_source.py
@@ -86,7 +86,7 @@ def __init__(
                 )
 
         super().__init__(
-            _name if _name else "",
+            name=_name if _name else "",
             event_timestamp_column=event_timestamp_column,
             created_timestamp_column=created_timestamp_column,
             field_mapping=field_mapping,

diff --git a/sdk/python/feast/infra/offline_stores/redshift_source.py b/sdk/python/feast/infra/offline_stores/redshift_source.py
@@ -80,7 +80,7 @@ def __init__(
             )
 
         super().__init__(
-            _name if _name else "",
+            name=_name if _name else "",
             event_timestamp_column=event_timestamp_column,
             created_timestamp_column=created_timestamp_column,
             field_mapping=field_mapping,

diff --git a/sdk/python/feast/infra/offline_stores/snowflake_source.py b/sdk/python/feast/infra/offline_stores/snowflake_source.py
@@ -82,7 +82,7 @@ def __init__(
             )
 
         super().__init__(
-            _name if _name else "",
+            name=_name if _name else "",
             event_timestamp_column=event_timestamp_column,
             created_timestamp_column=created_timestamp_column,
             field_mapping=field_mapping,