CR updates

Signed-off-by: Achal Shah <[email protected]>
feast-dev · Sep 9, 2021 · bb914b6 · bb914b6
1 parent 729e77d
commit bb914b6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py
@@ -892,10 +892,7 @@ def _augment_response_with_on_demand_transforms(
 
         odfv_feature_refs = defaultdict(list)
         for feature_ref in feature_refs:
-            view_name, feature_name = (
-                feature_ref.split(":")[0],
-                feature_ref.split(":")[1],
-            )
+            view_name, feature_name = feature_ref.split(":")
             if view_name in all_odfv_feature_names:
                 odfv_feature_refs[view_name].append(feature_name)
 

diff --git a/sdk/python/feast/type_map.py b/sdk/python/feast/type_map.py
@@ -81,7 +81,7 @@ def feast_value_type_to_pandas_type(value_type: ValueType) -> Any:
         ValueType.DOUBLE: "float",
         ValueType.BYTES: "bytes",
         ValueType.BOOL: "bool",
-        ValueType.UNIX_TIMESTAMP: "Timestamp",
+        ValueType.UNIX_TIMESTAMP: "datetime",
     }
     if value_type in value_type_to_pandas_type:
         return value_type_to_pandas_type[value_type]