Skip to content

Commit

Permalink
fix: Remove unnecessary peer dependencies from Feast UI (#4577)
Browse files Browse the repository at this point in the history
  • Loading branch information
peruukki authored Sep 26, 2024
1 parent 3198371 commit 9ac7f4e
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 16 deletions.
7 changes: 5 additions & 2 deletions docs/reference/alpha-web-ui.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,14 @@ Start with bootstrapping a React app with `create-react-app`
npx create-react-app your-feast-ui
```

Then, in your app folder, install Feast UI and its peer dependencies. Assuming you use yarn
Then, in your app folder, install Feast UI and optionally its peer dependencies. Assuming you use yarn

```
yarn add @feast-dev/feast-ui
yarn add @elastic/eui @elastic/datemath @emotion/react moment prop-types inter-ui react-query react-router-dom use-query-params zod typescript query-string d3 @types/d3
# For custom UI using the Elastic UI Framework (optional):
yarn add @elastic/eui
# For general custom styling (optional):
yarn add @emotion/react
```

Edit `index.js` in the React app to use Feast UI.
Expand Down
7 changes: 5 additions & 2 deletions ui/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,14 @@ Start with bootstrapping a React app with `create-react-app`
npx create-react-app your-feast-ui
```

Then, in your app folder, install Feast UI and its peer dependencies. Assuming you use yarn
Then, in your app folder, install Feast UI and optionally its peer dependencies. Assuming you use yarn

```
yarn add @feast-dev/feast-ui
yarn add @elastic/eui @elastic/datemath @emotion/react moment prop-types inter-ui react-query react-router-dom use-query-params zod typescript query-string d3 @types/d3
# For custom UI using the Elastic UI Framework (optional):
yarn add @elastic/eui
# For general custom styling (optional):
yarn add @emotion/react
```

Edit `index.js` in the React app to use Feast UI.
Expand Down
21 changes: 9 additions & 12 deletions ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,18 @@
"types": "./dist/FeastUI.d.ts",
"module": "./dist/feast-ui.module.js",
"peerDependencies": {
"@elastic/datemath": "^5.0.3",
"@elastic/eui": "^55.0.1",
"@emotion/react": "^11.7.1",
"d3": "^7.3.0",
"inter-ui": "^3.19.3",
"moment": "^2.29.1",
"prop-types": "^15.8.1",
"query-string": "^7.1.1",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-query": "^3.34.12",
"react-router-dom": "<6.4.0",
"react-scripts": "^5.0.0",
"use-query-params": "^1.2.3",
"zod": "^3.11.6"
"react-dom": "^17.0.2"
},
"peerDependenciesMeta": {
"@elastic/eui": {
"optional": true
},
"@emotion/react": {
"optional": true
}
},
"dependencies": {
"@elastic/datemath": "^5.0.3",
Expand Down

0 comments on commit 9ac7f4e

Please sign in to comment.