Skip to content

Commit

Permalink
Preserve ordering of features in _get_column_names
Browse files Browse the repository at this point in the history
  • Loading branch information
mavysavydav authored Mar 26, 2022
1 parent 356788a commit 5f126fb
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions sdk/python/feast/infra/provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -290,9 +290,10 @@ def _get_column_names(

# We need to exclude join keys and timestamp columns from the list of features, after they are mapped to
# their final column names via the `field_mapping` field of the source.
_feature_names = set(feature_names) - set(join_keys)
_feature_names = _feature_names - {event_timestamp_column, created_timestamp_column}
feature_names = list(_feature_names)
feature_names = [name for name in feature_names
if name not in join_keys
and not event_timestamp_column
and not created_timestamp_column]
return (
join_keys,
feature_names,
Expand Down

0 comments on commit 5f126fb

Please sign in to comment.