fix serialization

Signed-off-by: Miles Adkins <[email protected]>
feast-dev · Jul 28, 2022 · 53aa4f7 · 53aa4f7
1 parent 48ae284
commit 53aa4f7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/sdk/python/feast/infra/online_stores/snowflake.py b/sdk/python/feast/infra/online_stores/snowflake.py
@@ -90,10 +90,11 @@ def online_write_batch(
 
             for j, (feature_name, val) in enumerate(values.items()):
                 df.loc[j, "entity_feature_key"] = serialize_entity_key(
-                    entity_key,
-                    entity_key_serialization_version=2
+                    entity_key, entity_key_serialization_version=2
                 ) + bytes(feature_name, encoding="utf-8")
-                df.loc[j, "entity_key"] = serialize_entity_key(entity_key, entity_key_serialization_version=2)
+                df.loc[j, "entity_key"] = serialize_entity_key(
+                    entity_key, entity_key_serialization_version=2
+                )
                 df.loc[j, "feature_name"] = feature_name
                 df.loc[j, "value"] = val.SerializeToString()
                 df.loc[j, "event_ts"] = timestamp
@@ -166,7 +167,9 @@ def online_read(
             )
 
         for entity_key in entity_keys:
-            entity_key_bin = serialize_entity_key(entity_key, entity_key_serialization_version=2)
+            entity_key_bin = serialize_entity_key(
+                entity_key, entity_key_serialization_version=2
+            )
             res = {}
             res_ts = None
             for index, row in df[df["entity_key"] == entity_key_bin].iterrows():

diff --git a/sdk/python/feast/templates/snowflake/feature_store.yaml b/sdk/python/feast/templates/snowflake/feature_store.yaml
@@ -9,7 +9,6 @@ offline_store:
     role: SNOWFLAKE_ROLE
     warehouse: SNOWFLAKE_WAREHOUSE
     database: SNOWFLAKE_DATABASE
-entity_key_serialization_version: 2
 online_store:
     type: snowflake.online
     account: SNOWFLAKE_DEPLOYMENT_URL