Refactor constants and add sphinx docs

Signed-off-by: Terence <[email protected]>
feast-dev · Nov 18, 2020 · 22838c8 · 22838c8
1 parent 977f659
commit 22838c8
Show file tree

Hide file tree

Showing 10 changed files with 329 additions and 315 deletions.
diff --git a/sdk/python/docs/index.rst b/sdk/python/docs/index.rst
@@ -33,4 +33,11 @@ Feature
 
 .. automodule:: feast.feature
     :inherited-members:
-    :members:
+    :members:
+
+Constants
+==================
+
+.. automodule:: feast.constants
+    :members:
+    :exclude-members: AuthProvider
diff --git a/sdk/python/feast/cli.py b/sdk/python/feast/cli.py
@@ -23,7 +23,7 @@
 
 from feast.client import Client
 from feast.config import Config
-from feast.constants import CONFIG_SPARK_LAUNCHER
+from feast.constants import ConfigOptions
 from feast.entity import Entity
 from feast.feature_table import FeatureTable
 from feast.job_service import start_job_service
@@ -422,7 +422,7 @@ def stop_stream_to_online(feature_table: str):
     Stop stream to online sync job
     """
 
-    spark_launcher = Config().get(CONFIG_SPARK_LAUNCHER)
+    spark_launcher = Config().get(ConfigOptions.SPARK_LAUNCHER)
 
     if spark_launcher == "emr":
         import feast.pyspark.aws.jobs
@@ -441,7 +441,7 @@ def list_jobs():
     """
     from tabulate import tabulate
 
-    spark_launcher = Config().get(CONFIG_SPARK_LAUNCHER)
+    spark_launcher = Config().get(ConfigOptions.SPARK_LAUNCHER)
 
     if spark_launcher == "emr":
         import feast.pyspark.aws.jobs