chore: Remove rest settings from java app properties (#3155)

The rest setting was not being used since the java server moved to being gRPC only. Specifying it is only likely to cause warnings/errors and confusion. Signed-off-by: Achal Shah <[email protected]> Signed-off-by: Achal Shah <[email protected]>
feast-dev · Aug 31, 2022 · 1ee39fe · 1ee39fe
1 parent cadc91e
commit 1ee39fe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 13 deletions.
diff --git a/java/serving/src/main/java/feast/serving/service/config/ApplicationProperties.java b/java/serving/src/main/java/feast/serving/service/config/ApplicationProperties.java
@@ -38,7 +38,6 @@ public class ApplicationProperties {
   private static final Logger log = org.slf4j.LoggerFactory.getLogger(ApplicationProperties.class);
   private FeastProperties feast;
   private GrpcServer grpc;
-  private RestServer rest;
 
   public FeastProperties getFeast() {
     return feast;
@@ -331,18 +330,6 @@ public void setServer(Server server) {
     }
   }
 
-  public static class RestServer {
-    private Server server;
-
-    public Server getServer() {
-      return server;
-    }
-
-    public void setServer(Server server) {
-      this.server = server;
-    }
-  }
-
   /** Trace metric collection properties */
   public static class TracingProperties {
 

diff --git a/java/serving/src/main/java/feast/serving/service/config/ApplicationPropertiesModule.java b/java/serving/src/main/java/feast/serving/service/config/ApplicationPropertiesModule.java
@@ -16,6 +16,7 @@
  */
 package feast.serving.service.config;
 
+import com.fasterxml.jackson.databind.DeserializationFeature;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.ObjectReader;
 import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
@@ -40,6 +41,7 @@ public ApplicationProperties provideApplicationProperties() throws IOException {
     ObjectMapper mapper = new ObjectMapper(new YAMLFactory());
     mapper.findAndRegisterModules();
     mapper.setDefaultMergeable(Boolean.TRUE);
+    mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
 
     ApplicationProperties properties = new ApplicationProperties();
     ObjectReader objectReader = mapper.readerForUpdating(properties);