chore: Create a registry base class (#2756)

* chore: Create a registry base class Signed-off-by: Achal Shah <[email protected]> * abstract methods Signed-off-by: Achal Shah <[email protected]> * implement missing methods Signed-off-by: Achal Shah <[email protected]> * implement missing methods Signed-off-by: Achal Shah <[email protected]> * remove dupe Signed-off-by: Achal Shah <[email protected]>
feast-dev · Jun 3, 2022 · 0d195c4 · 0d195c4
1 parent b3fe39c
commit 0d195c4
Show file tree

Hide file tree

Showing 5 changed files with 468 additions and 6 deletions.
diff --git a/.github/workflows/pr_integration_tests.yml b/.github/workflows/pr_integration_tests.yml
@@ -170,7 +170,7 @@ jobs:
           SNOWFLAKE_CI_PASSWORD: ${{ secrets.SNOWFLAKE_CI_PASSWORD }}
           SNOWFLAKE_CI_ROLE: ${{ secrets.SNOWFLAKE_CI_ROLE }}
           SNOWFLAKE_CI_WAREHOUSE: ${{ secrets.SNOWFLAKE_CI_WAREHOUSE }}
-        run: pytest -n 8 --cov=./ --cov-report=xml --verbose --color=yes sdk/python/tests --integration --durations=5
+        run: pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v1
         with:

diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml
@@ -66,7 +66,7 @@ jobs:
           SNOWFLAKE_CI_PASSWORD: ${{ secrets.SNOWFLAKE_CI_PASSWORD }}
           SNOWFLAKE_CI_ROLE: ${{ secrets.SNOWFLAKE_CI_ROLE }}
           SNOWFLAKE_CI_WAREHOUSE: ${{ secrets.SNOWFLAKE_CI_WAREHOUSE }}
-        run: FEAST_USAGE=False pytest -n 8 --cov=./ --cov-report=xml --verbose --color=yes sdk/python/tests
+        run: FEAST_USAGE=False pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v1
         with:

diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py
@@ -646,7 +646,8 @@ def _plan(
         self._registry.refresh()
         current_infra_proto = (
             self._registry.cached_registry_proto.infra.__deepcopy__()
-            if self._registry.cached_registry_proto
+            if hasattr(self._registry, "cached_registry_proto")
+            and self._registry.cached_registry_proto
             else InfraProto()
         )
         desired_registry_proto = desired_repo_contents.to_registry_proto()

diff --git a/sdk/python/feast/infra/registry_stores/sql.py b/sdk/python/feast/infra/registry_stores/sql.py
@@ -48,10 +48,11 @@
 from feast.protos.feast.core.ValidationProfile_pb2 import (
     ValidationReference as ValidationReferenceProto,
 )
-from feast.registry import Registry
+from feast.registry import BaseRegistry
 from feast.repo_config import RegistryConfig
 from feast.request_feature_view import RequestFeatureView
 from feast.saved_dataset import SavedDataset, ValidationReference
+from feast.stream_feature_view import StreamFeatureView
 
 metadata = MetaData()
 
@@ -121,7 +122,7 @@
 )
 
 
-class SqlRegistry(Registry):
+class SqlRegistry(BaseRegistry):
     def __init__(
         self, registry_config: Optional[RegistryConfig], repo_path: Optional[Path]
     ):
@@ -152,6 +153,11 @@ def teardown(self):
     def refresh(self):
         pass
 
+    def list_stream_feature_views(
+        self, project: str, allow_cache: bool = False
+    ) -> List[StreamFeatureView]:
+        return []
+
     def apply_entity(self, entity: Entity, project: str, commit: bool = True):
         return self._apply_object(entities, "entity_name", entity, "entity_proto")
 
@@ -389,6 +395,22 @@ def apply_validation_reference(
             "validation_reference_proto",
         )
 
+    def apply_materialization(
+        self,
+        feature_view: FeatureView,
+        project: str,
+        start_date: datetime,
+        end_date: datetime,
+        commit: bool = True,
+    ):
+        pass
+
+    def delete_validation_reference(self, name: str, project: str, commit: bool = True):
+        pass
+
+    def commit(self):
+        pass
+
     def _apply_object(
         self, table, id_field_name, obj, proto_field_name,
     ):