Skip to content

Commit

Permalink
Set default build version in Feast Core "version" field in Feast Prop…
Browse files Browse the repository at this point in the history
…erties
  • Loading branch information
woop committed Apr 11, 2020
1 parent 381dd59 commit 03e5673
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
6 changes: 2 additions & 4 deletions core/src/main/java/feast/core/config/FeastProperties.java
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,10 @@ public FeastProperties(BuildProperties buildProperties) {
setVersion(buildProperties.getVersion());
}

public FeastProperties() {
setVersion("unknown");
}
public FeastProperties() {}

/* Feast Core Build Version */
@NotBlank private String version;
@NotBlank private String version = "unknown";

/* Population job properties */
@NotNull private JobProperties jobs;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@
import feast.serving.specs.CachedSpecService;
import feast.serving.specs.CoreSpecService;
import feast.storage.api.retriever.FeatureSetRequest;
import java.io.BufferedWriter;
import java.io.File;
import java.io.FileWriter;
import java.io.IOException;
import java.util.Collections;
import java.util.LinkedHashMap;
import java.util.List;
Expand Down

0 comments on commit 03e5673

Please sign in to comment.