Catch errors thrown by BQ during entity table loading (#371)

* Catch errors thrown by BQ during entity table loading * Apply spotless * Add logging at grpc service level
feast-dev · Dec 17, 2019 · 03b3135 · 03b3135
1 parent f2d4db5
commit 03b3135
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/serving/src/main/java/feast/serving/controller/ServingServiceGRpcController.java b/serving/src/main/java/feast/serving/controller/ServingServiceGRpcController.java
@@ -74,6 +74,7 @@ public void getOnlineFeatures(
       responseObserver.onNext(onlineFeatures);
       responseObserver.onCompleted();
     } catch (Exception e) {
+      log.warn("Failed to get Online Features", e);
       responseObserver.onError(e);
     }
     span.finish();
@@ -88,6 +89,7 @@ public void getBatchFeatures(
       responseObserver.onNext(batchFeatures);
       responseObserver.onCompleted();
     } catch (Exception e) {
+      log.warn("Failed to get Batch Features", e);
       responseObserver.onError(e);
     }
   }
@@ -99,6 +101,7 @@ public void getJob(GetJobRequest request, StreamObserver<GetJobResponse> respons
       responseObserver.onNext(response);
       responseObserver.onCompleted();
     } catch (Exception e) {
+      log.warn("Failed to get Job", e);
       responseObserver.onError(e);
     }
   }

diff --git a/serving/src/main/java/feast/serving/service/BigQueryServingService.java b/serving/src/main/java/feast/serving/service/BigQueryServingService.java
@@ -123,17 +123,26 @@ public GetBatchFeaturesResponse getBatchFeatures(GetBatchFeaturesRequest getFeat
           .asRuntimeException();
     }
 
-    Table entityTable = loadEntities(getFeaturesRequest.getDatasetSource());
+    Table entityTable;
+    String entityTableName;
+    try {
+      entityTable = loadEntities(getFeaturesRequest.getDatasetSource());
+
+      TableId entityTableWithUUIDs = generateUUIDs(entityTable);
+      entityTableName = generateFullTableName(entityTableWithUUIDs);
+    } catch (Exception e) {
+      throw Status.INTERNAL
+          .withDescription("Unable to load entity dataset to Bigquery")
+          .asRuntimeException();
+    }
+
     Schema entityTableSchema = entityTable.getDefinition().getSchema();
     List<String> entityNames =
         entityTableSchema.getFields().stream()
             .map(Field::getName)
             .filter(name -> !name.equals("event_timestamp"))
             .collect(Collectors.toList());
 
-    TableId entityTableWithUUIDs = generateUUIDs(entityTable);
-    String entityTableName = generateFullTableName(entityTableWithUUIDs);
-
     List<FeatureSetInfo> featureSetInfos =
         QueryTemplater.getFeatureSetInfos(featureSetSpecs, getFeaturesRequest.getFeatureSetsList());