Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

😈 is a devil #151

Closed
wants to merge 1 commit into from
Closed

😈 is a devil #151

wants to merge 1 commit into from

Conversation

ncfavier
Copy link
Contributor

@ncfavier ncfavier commented Aug 5, 2023

No description provided.

@fdw
Copy link
Owner

fdw commented Aug 11, 2023

Hey, thanks for the PR 🙂

Unfortunately, these files are automatically generated from the official Unicode documentation. So any changes here will be wiped the next time I update everything.
However, you could add the entry to src/picker/data/additional/emojis_smileys_emotion.csv (which doesn't exist yet, but feel free to create it). Then it will be loaded automatically and not overwritten on updates.

@ncfavier
Copy link
Contributor Author

Like this?

@fdw
Copy link
Owner

fdw commented Aug 12, 2023

Almost - the descriptions will be appended, so you don't need to repeat the original one. Just leave your new annotations, and it should work 🙂

@@ -0,0 +1 @@
😈 smiling face with horns <small>(demon, devil, imp)</small>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can also skip smiling face with horns <small>, just leaving demon, devil, imp.
Have you tried locally how it looks?

@ncfavier ncfavier closed this Aug 14, 2023
@fdw
Copy link
Owner

fdw commented Aug 16, 2023

Hey, I'm sorry you closed this PR. Could I have done anything better? Do you want me to add your changes (with you as co-author, of course)?

@ncfavier
Copy link
Contributor Author

I expected this to be a trivial 1-minute fix and not to have to set up any infrastructure. It's fine, I just don't care enough. Do what you want.

@fdw
Copy link
Owner

fdw commented Aug 16, 2023

I see, thank you 🙂 Unfortunately, you were the first person to improve the descriptions with the new setup, so there was nothing to use as an example.

I think I'll take your changes to make it easier for the next person.

Thank you and have a good day 🙂

fdw added a commit that referenced this pull request Aug 17, 2023
Issue: #151

Co-authored-by: Naïm Favier <[email protected]>
Co-authored-by: Fabian Winter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants