Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text2Bin on PJX errors out for projects with an attach icon that has a drive letter on its path. #93

Closed
ericbarte opened this issue Mar 16, 2023 · 2 comments

Comments

@ericbarte
Copy link

ericbarte commented Mar 16, 2023

ℹ Computer information

  • VFP version: 9
  • FoxBin2PRG version: 1.19.76
  • Last FoxBin2PRG version w/o bug (if available):

📝 Provide detailed reproduction steps (if any)

  1. Create a new project.
  2. Go to Project > Project Info > Attach Icon.
  3. Choose an icon that's from a different drive.
  4. Do a Bin2Text to create the PJ2 file.
  5. Do a Text2Bin. Errors out.

✔️ Expected result

It should regenerate the PJX/T files.

❌ Actual result

Error log has "Error 202, Invalid path or file name."

📷 Config

Do not include your normal config.
Please add your current full configuration.
Create a config file via DO FOXBIN2PRG.PRG WITH '-C','path-to-source\FoxBin.cfg' , zip and add here.

📷 Screenshots

Are there any useful screenshots? WinKey+Shift+S and then just paste them directly into the form

@lscheffler
Copy link
Collaborator

@ericbarte The icon is stored in the form
.Icon = lcCurdir + 'd:\Path\my.ico'
Obviously this will fail.


I fear it will not help you, but FoxBin2Prg is not designed to operate this way. It's clearly set up to deal with the classical mode where all the sources are in the directory or subdirectories of the place where the pjx is stored.
Since the project is made to deal with source control, it's impossible to tell where (on which drive) a project will be recreated. The use of drive letters makes no sense under this circumstance. And, from a source control POV, I have no idea how to include such a file into a source control at all.
I agree that it should not fail and possibly deny to create the text file in the first place, but your problem is true to any file stored in the PJX, not only the icon of the project.

To fix your problem, I suggest that you open the pj2 with an editor of your choice, look up the icon and remove the whole line. You can try to remove the lcCurdir + part and look if it recreates the pjx.
If you really need this function I suggest to fork the project.


NOTE: If you choose to have binary tables outside the path given by your project, the result of FoxBin2PRG might be unexpected, since the config files are valid for there folder and subfolders, not for a project.

lscheffler added a commit that referenced this issue Mar 16, 2023
Updates to documentation for issue #93
lscheffler added a commit that referenced this issue Mar 16, 2023
Updates to documentation for issue #93
 links to issue set
lscheffler added a commit that referenced this issue Mar 20, 2023
Text2Bin on PJX errors out for projects with an attach icon that has a drive letter on its path. Closing #93
@lscheffler
Copy link
Collaborator

@ericbarte See this how to solve your problem with the new version.

lscheffler added a commit that referenced this issue Aug 5, 2023
Text2Bin on PJX errors out for projects with an attach icon that has a drive letter on its path. Closing #93
lscheffler added a commit to lscheffler/foxbin2prg that referenced this issue Aug 5, 2023
Updates to documentation for issue fdbozzo#93
lscheffler added a commit to lscheffler/foxbin2prg that referenced this issue Aug 5, 2023
Updates to documentation for issue fdbozzo#93
 links to issue set
lscheffler added a commit to lscheffler/foxbin2prg that referenced this issue Aug 5, 2023
Text2Bin on PJX errors out for projects with an attach icon that has a drive letter on its path. Closing fdbozzo#93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants