Fcrepo-2954 - Add headers #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awoods
requested changes
Nov 29, 2018
| } | ||
|
|
||
| @Override | ||
| protected DeleteBuilder addLinkHeader(final FcrepoLink linkHeader) { |
There was a problem hiding this comment.
Link on Delete? I am not sure the use case exists.
| } | ||
|
|
||
| @Override | ||
| protected MoveBuilder addLinkHeader(final FcrepoLink linkHeader) { |
There was a problem hiding this comment.
Link on Move? I am not sure the use case exists.
bbpennel
force-pushed
the
fcrepo-2954-headers
branch
2 times, most recently
from
caa044a to
a3ef4cb
Compare
|
@awoods I have removed the |
…s (not needed for HistoricMementoBuilder since it falls back to PostBuilder). Fix visibility of methods in builders.
bbpennel
force-pushed
the
fcrepo-2954-headers
branch
from
a3ef4cb to
95ab0e0
Compare
awoods
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: https://jira.duraspace.org/browse/FCREPO-2954
What does this Pull Request do?
Adds methods for adding arbitrary headers.
What's new?
Adds
.addHeaderand.addLinkHeaderto all terminal request builders.How should this be tested?
mvn clean installAdditional Notes:
I left out .addHeader(Header) on the assumption we didn't want to expose the underlying dependency on HttpClient. I also didn't add a setHeader method, since it seemed a little odd for a builder, but I'm not opposed to including one.
Interested parties
@awoods