Adding disposition to PostBuilder, and filename/disposition to PutBuilder #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awoods
reviewed
May 26, 2017
| * @param disposition the disposition value | ||
| * @return this builder | ||
| **/ | ||
| public PostBuilder disposition(final String disposition) { |
There was a problem hiding this comment.
The only valid value for disposition is: attachment *( ";" disposition-parm )
see: https://www.w3.org/Protocols/rfc2616/rfc2616-sec19.html#sec19.5.1
..which means that a user-provided value that is not either attachment or attachment; filename=... would not be valid.
Since @birkland's use case uses Content-Disposition: attachment, maybe it makes sense to allow a null in the existing method in which case the ; filename=... can be left off.
There was a problem hiding this comment.
@awoods OK, I thought that there were more options, but since there aren't, just accepting null to create the plain attachment variation seems like the easiest thing to do here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dispositionmethod to PostBuilderdispositionandfilenamemethods to PutBuilderFixes https://jira.duraspace.org/browse/FCREPO-2502