remove reference to blueprint.js in css (jupyterlab#12663)

* remove reference to blueprint.js in css * remove more blueprint.js overrides * add back the color and font-size rules for the body * Fix Card styles * Restore unset outline on focus * Update Playwright Snapshots Update Playwright Snapshots Update Playwright Snapshots Update snapshots * Update snapshots Co-authored-by: Eric Charles <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
fcollonval · Jul 6, 2022 · 62ea73b · 62ea73b
1 parent 6bf3f3b
commit 62ea73b
Show file tree

Hide file tree

Showing 82 changed files with 8 additions and 37 deletions.
diff --git a/...customization.test.ts-snapshots/customized-context-menu-documentation-linux.png b/...customization.test.ts-snapshots/customized-context-menu-documentation-linux.png
diff --git a/...ion/customization.test.ts-snapshots/customized-menu-bar-documentation-linux.png b/...ion/customization.test.ts-snapshots/customized-menu-bar-documentation-linux.png
diff --git a/...n.test.ts-snapshots/customized-terminal-position-single-documentation-linux.png b/...n.test.ts-snapshots/customized-terminal-position-single-documentation-linux.png
diff --git a/...on/customization.test.ts-snapshots/default-context-menu-documentation-linux.png b/...on/customization.test.ts-snapshots/default-context-menu-documentation-linux.png
diff --git a/...tation/customization.test.ts-snapshots/default-menu-bar-documentation-linux.png b/...tation/customization.test.ts-snapshots/default-menu-bar-documentation-linux.png
diff --git a/...tion.test.ts-snapshots/default-terminal-position-single-documentation-linux.png b/...tion.test.ts-snapshots/default-terminal-position-single-documentation-linux.png
diff --git a/...entation/debugger.test.ts-snapshots/debugger-breakpoint-documentation-linux.png b/...entation/debugger.test.ts-snapshots/debugger-breakpoint-documentation-linux.png
diff --git a/...cumentation/debugger.test.ts-snapshots/debugger-sidebar-documentation-linux.png b/...cumentation/debugger.test.ts-snapshots/debugger-sidebar-documentation-linux.png
diff --git a/...mentation/debugger.test.ts-snapshots/debugger-variables-documentation-linux.png b/...mentation/debugger.test.ts-snapshots/debugger-variables-documentation-linux.png
diff --git a/...tation/export_notebook.test.ts-snapshots/exporting-menu-documentation-linux.png b/...tation/export_notebook.test.ts-snapshots/exporting-menu-documentation-linux.png
diff --git a/.../export_notebook.test.ts-snapshots/exporting-slide-type-documentation-linux.png b/.../export_notebook.test.ts-snapshots/exporting-slide-type-documentation-linux.png
diff --git a/...nsion_manager.test.ts-snapshots/extensions-allowed-list-documentation-linux.png b/...nsion_manager.test.ts-snapshots/extensions-allowed-list-documentation-linux.png
diff --git a/...nsion_manager.test.ts-snapshots/extensions-blocked-list-documentation-linux.png b/...nsion_manager.test.ts-snapshots/extensions-blocked-list-documentation-linux.png
diff --git a/.../extension_manager.test.ts-snapshots/extensions-default-documentation-linux.png b/.../extension_manager.test.ts-snapshots/extensions-default-documentation-linux.png
diff --git a/...extension_manager.test.ts-snapshots/extensions-disabled-documentation-linux.png b/...extension_manager.test.ts-snapshots/extensions-disabled-documentation-linux.png
diff --git a/.../extension_manager.test.ts-snapshots/extensions-enabled-documentation-linux.png b/.../extension_manager.test.ts-snapshots/extensions-enabled-documentation-linux.png
diff --git a/...n/extension_manager.test.ts-snapshots/extensions-search-documentation-linux.png b/...n/extension_manager.test.ts-snapshots/extensions-search-documentation-linux.png
diff --git a/...r.test.ts-snapshots/extensions-simultaneous-block-allow-documentation-linux.png b/...r.test.ts-snapshots/extensions-simultaneous-block-allow-documentation-linux.png
diff --git a/...documentation/general.test.ts-snapshots/command-palette-documentation-linux.png b/...documentation/general.test.ts-snapshots/command-palette-documentation-linux.png
diff --git a/...entation/general.test.ts-snapshots/file-editor-overview-documentation-linux.png b/...entation/general.test.ts-snapshots/file-editor-overview-documentation-linux.png
diff --git a/...entation/general.test.ts-snapshots/file-editor-settings-documentation-linux.png b/...entation/general.test.ts-snapshots/file-editor-settings-documentation-linux.png
diff --git a/...mentation/general.test.ts-snapshots/file-formats-altair-documentation-linux.png b/...mentation/general.test.ts-snapshots/file-formats-altair-documentation-linux.png
diff --git a/...ion/general.test.ts-snapshots/file-formats-html-display-documentation-linux.png b/...ion/general.test.ts-snapshots/file-formats-html-display-documentation-linux.png
diff --git a/...ion/general.test.ts-snapshots/file-formats-nteract-vdom-documentation-linux.png b/...ion/general.test.ts-snapshots/file-formats-nteract-vdom-documentation-linux.png
diff --git a/...tation/general.test.ts-snapshots/file-formats-open-with-documentation-linux.png b/...tation/general.test.ts-snapshots/file-formats-open-with-documentation-linux.png
diff --git a/...documentation/general.test.ts-snapshots/files-menu-left-documentation-linux.png b/...documentation/general.test.ts-snapshots/files-menu-left-documentation-linux.png
diff --git a/...entation/general.test.ts-snapshots/files-shareable-link-documentation-linux.png b/...entation/general.test.ts-snapshots/files-shareable-link-documentation-linux.png
diff --git a/...entation/general.test.ts-snapshots/interface-jupyterlab-documentation-linux.png b/...entation/general.test.ts-snapshots/interface-jupyterlab-documentation-linux.png
diff --git a/.../documentation/general.test.ts-snapshots/interface-left-documentation-linux.png b/.../documentation/general.test.ts-snapshots/interface-left-documentation-linux.png
diff --git a/...documentation/general.test.ts-snapshots/interface-right-documentation-linux.png b/...documentation/general.test.ts-snapshots/interface-right-documentation-linux.png
diff --git a/.../documentation/general.test.ts-snapshots/interface-tabs-documentation-linux.png b/.../documentation/general.test.ts-snapshots/interface-tabs-documentation-linux.png
diff --git a/...mentation/general.test.ts-snapshots/interface-tabs-menu-documentation-linux.png b/...mentation/general.test.ts-snapshots/interface-tabs-menu-documentation-linux.png
diff --git a/...test/documentation/general.test.ts-snapshots/jupyterlab-documentation-linux.png b/...test/documentation/general.test.ts-snapshots/jupyterlab-documentation-linux.png
diff --git a/...est/documentation/general.test.ts-snapshots/notebook-ui-documentation-linux.png b/...est/documentation/general.test.ts-snapshots/notebook-ui-documentation-linux.png
diff --git a/.../documentation/general.test.ts-snapshots/running-layout-documentation-linux.png b/.../documentation/general.test.ts-snapshots/running-layout-documentation-linux.png
diff --git a/...documentation/general.test.ts-snapshots/terminal-layout-documentation-linux.png b/...documentation/general.test.ts-snapshots/terminal-layout-documentation-linux.png
diff --git a/.../internationalization.test.ts-snapshots/language-change-documentation-linux.png b/.../internationalization.test.ts-snapshots/language-change-documentation-linux.png
diff --git a/...internationalization.test.ts-snapshots/language-chinese-documentation-linux.png b/...internationalization.test.ts-snapshots/language-chinese-documentation-linux.png
diff --git a/...nternationalization.test.ts-snapshots/language-settings-documentation-linux.png b/...nternationalization.test.ts-snapshots/language-settings-documentation-linux.png
diff --git a/galata/test/galata/notebook.spec.ts-snapshots/example-run-galata-linux.png b/galata/test/galata/notebook.spec.ts-snapshots/example-run-galata-linux.png
diff --git a/...collapsible-headings.test.ts-snapshots/add-header-below-01-jupyterlab-linux.png b/...collapsible-headings.test.ts-snapshots/add-header-below-01-jupyterlab-linux.png
diff --git a/...collapsible-headings.test.ts-snapshots/add-header-below-02-jupyterlab-linux.png b/...collapsible-headings.test.ts-snapshots/add-header-below-02-jupyterlab-linux.png
diff --git a/...collapsible-headings.test.ts-snapshots/add-header-below-03-jupyterlab-linux.png b/...collapsible-headings.test.ts-snapshots/add-header-below-03-jupyterlab-linux.png
diff --git a/...psible-headings.test.ts-snapshots/collapse-previous-header-jupyterlab-linux.png b/...psible-headings.test.ts-snapshots/collapse-previous-header-jupyterlab-linux.png
diff --git a/...sible-headings.test.ts-snapshots/collapse-previous-headers-jupyterlab-linux.png b/...sible-headings.test.ts-snapshots/collapse-previous-headers-jupyterlab-linux.png
diff --git a/...collapsible-headings.test.ts-snapshots/reexpand-headers-01-jupyterlab-linux.png b/...collapsible-headings.test.ts-snapshots/reexpand-headers-01-jupyterlab-linux.png
diff --git a/...collapsible-headings.test.ts-snapshots/reexpand-headers-02-jupyterlab-linux.png b/...collapsible-headings.test.ts-snapshots/reexpand-headers-02-jupyterlab-linux.png
diff --git a/...ollapsible-headings.test.ts-snapshots/reexpand-headers-03a-jupyterlab-linux.png b/...ollapsible-headings.test.ts-snapshots/reexpand-headers-03a-jupyterlab-linux.png
diff --git a/...ollapsible-headings.test.ts-snapshots/reexpand-headers-03b-jupyterlab-linux.png b/...ollapsible-headings.test.ts-snapshots/reexpand-headers-03b-jupyterlab-linux.png
diff --git a/...psible-headings.test.ts-snapshots/showHCB-collapse-heading-jupyterlab-linux.png b/...psible-headings.test.ts-snapshots/showHCB-collapse-heading-jupyterlab-linux.png
diff --git a/...ugger.test.ts-snapshots/start-debug-session-script-sources-jupyterlab-linux.png b/...ugger.test.ts-snapshots/start-debug-session-script-sources-jupyterlab-linux.png
diff --git a/...ger.test.ts-snapshots/start-debug-session-script-variables-jupyterlab-linux.png b/...ger.test.ts-snapshots/start-debug-session-script-variables-jupyterlab-linux.png
diff --git a/...lab/debugger.test.ts-snapshots/start-debug-session-sources-jupyterlab-linux.png b/...lab/debugger.test.ts-snapshots/start-debug-session-sources-jupyterlab-linux.png
diff --git a/...b/debugger.test.ts-snapshots/start-debug-session-variables-jupyterlab-linux.png b/...b/debugger.test.ts-snapshots/start-debug-session-variables-jupyterlab-linux.png
diff --git a/galata/test/jupyterlab/general.test.ts-snapshots/dark-theme-jupyterlab-linux.png b/galata/test/jupyterlab/general.test.ts-snapshots/dark-theme-jupyterlab-linux.png
diff --git a/galata/test/jupyterlab/general.test.ts-snapshots/launch-jupyterlab-linux.png b/galata/test/jupyterlab/general.test.ts-snapshots/launch-jupyterlab-linux.png
diff --git a/galata/test/jupyterlab/general.test.ts-snapshots/simple-mode-jupyterlab-linux.png b/galata/test/jupyterlab/general.test.ts-snapshots/simple-mode-jupyterlab-linux.png
diff --git a/.../jupyterlab/notebook-replace.test.ts-snapshots/replace-all-jupyterlab-linux.png b/.../jupyterlab/notebook-replace.test.ts-snapshots/replace-all-jupyterlab-linux.png
diff --git a/...yterlab/notebook-replace.test.ts-snapshots/replace-in-cell-jupyterlab-linux.png b/...yterlab/notebook-replace.test.ts-snapshots/replace-in-cell-jupyterlab-linux.png
diff --git a/...jupyterlab/notebook-run.test.ts-snapshots/notebook-panel-0-jupyterlab-linux.png b/...jupyterlab/notebook-run.test.ts-snapshots/notebook-panel-0-jupyterlab-linux.png
diff --git a/...notebook-search.test.ts-snapshots/highlight-next-in-editor-jupyterlab-linux.png b/...notebook-search.test.ts-snapshots/highlight-next-in-editor-jupyterlab-linux.png
diff --git a/...tebook-search.test.ts-snapshots/highlight-previous-element-jupyterlab-linux.png b/...tebook-search.test.ts-snapshots/highlight-previous-element-jupyterlab-linux.png
diff --git a/...notebook-search.test.ts-snapshots/search-in-selected-cells-jupyterlab-linux.png b/...notebook-search.test.ts-snapshots/search-in-selected-cells-jupyterlab-linux.png
diff --git a/...a/test/jupyterlab/notebook-search.test.ts-snapshots/search-jupyterlab-linux.png b/...a/test/jupyterlab/notebook-search.test.ts-snapshots/search-jupyterlab-linux.png
diff --git a/...b/notebook-search.test.ts-snapshots/search-on-deleted-cell-jupyterlab-linux.png b/...b/notebook-search.test.ts-snapshots/search-on-deleted-cell-jupyterlab-linux.png
diff --git a/...erlab/notebook-search.test.ts-snapshots/search-on-new-cell-jupyterlab-linux.png b/...erlab/notebook-search.test.ts-snapshots/search-on-new-cell-jupyterlab-linux.png
diff --git a/...ab/notebook-search.test.ts-snapshots/search-within-outputs-jupyterlab-linux.png b/...ab/notebook-search.test.ts-snapshots/search-within-outputs-jupyterlab-linux.png
diff --git a/...st/jupyterlab/sidebars.test.ts-snapshots/filebrowser-right-jupyterlab-linux.png b/...st/jupyterlab/sidebars.test.ts-snapshots/filebrowser-right-jupyterlab-linux.png
diff --git a/...est.ts-snapshots/opened-sidebar-extensionmanager-main-view-jupyterlab-linux.png b/...est.ts-snapshots/opened-sidebar-extensionmanager-main-view-jupyterlab-linux.png
diff --git a/...rlab/sidebars.test.ts-snapshots/opened-sidebar-filebrowser-jupyterlab-linux.png b/...rlab/sidebars.test.ts-snapshots/opened-sidebar-filebrowser-jupyterlab-linux.png
diff --git a/...ars.test.ts-snapshots/opened-sidebar-jp-property-inspector-jupyterlab-linux.png b/...ars.test.ts-snapshots/opened-sidebar-jp-property-inspector-jupyterlab-linux.png
diff --git a/...ebars.test.ts-snapshots/opened-sidebar-jp-running-sessions-jupyterlab-linux.png b/...ebars.test.ts-snapshots/opened-sidebar-jp-running-sessions-jupyterlab-linux.png
diff --git a/...idebars.test.ts-snapshots/opened-sidebar-table-of-contents-jupyterlab-linux.png b/...idebars.test.ts-snapshots/opened-sidebar-table-of-contents-jupyterlab-linux.png
diff --git a/...-running.test.ts-snapshots/toc-running-indicator-top-level-jupyterlab-linux.png b/...-running.test.ts-snapshots/toc-running-indicator-top-level-jupyterlab-linux.png
diff --git a/...erlab/toc-running.test.ts-snapshots/toc-running-indicators-jupyterlab-linux.png b/...erlab/toc-running.test.ts-snapshots/toc-running-indicators-jupyterlab-linux.png
diff --git a/.../jupyterlab/toc.test.ts-snapshots/notebook-output-headings-jupyterlab-linux.png b/.../jupyterlab/toc.test.ts-snapshots/notebook-output-headings-jupyterlab-linux.png
diff --git a/galata/test/jupyterlab/toc.test.ts-snapshots/toc-panel-jupyterlab-linux.png b/galata/test/jupyterlab/toc.test.ts-snapshots/toc-panel-jupyterlab-linux.png
diff --git a/...test/jupyterlab/toc.test.ts-snapshots/toggle-numbered-list-jupyterlab-linux.png b/...test/jupyterlab/toc.test.ts-snapshots/toggle-numbered-list-jupyterlab-linux.png
diff --git a/...est/jupyterlab/workspace.test.ts-snapshots/workspace-reset-jupyterlab-linux.png b/...est/jupyterlab/workspace.test.ts-snapshots/workspace-reset-jupyterlab-linux.png
diff --git a/...yterlab/workspace.test.ts-snapshots/workspace-simple-reset-jupyterlab-linux.png b/...yterlab/workspace.test.ts-snapshots/workspace-simple-reset-jupyterlab-linux.png
diff --git a/packages/launcher/style/base.css b/packages/launcher/style/base.css
@@ -166,6 +166,7 @@
   line-height: 14px;
   font-size: 12px;
   overflow: hidden;
+  margin: auto;
 }
 
 /* kernel icons */

diff --git a/packages/ui-components/style/base.css b/packages/ui-components/style/base.css
@@ -19,39 +19,9 @@
 @import './switch.css';
 @import './toolbar.css';
 
-/* Override Blueprint's _reset.scss styles */
-html {
-  box-sizing: unset;
-}
-
-*,
-*::before,
-*::after {
-  box-sizing: unset;
-}
-
 body {
   color: var(--jp-ui-font-color1);
   font-size: var(--jp-ui-font-size1);
-
-  /* Blueprint reset rules */
-  font-weight: 400;
-  letter-spacing: 0;
-  line-height: 1.28581;
-  text-transform: none;
-}
-
-p {
-  margin-top: unset;
-  margin-bottom: unset;
-}
-
-small {
-  font-size: unset;
-}
-
-strong {
-  font-weight: unset;
 }
 
 /* Disable native link decoration styles everywhere outside of dialog boxes */
@@ -65,6 +35,13 @@ a:hover {
   color: unset;
 }
 
+/* Disable default focus outline */
+:focus {
+  outline: unset;
+  outline-offset: unset;
+  -moz-outline-radius: unset;
+}
+
 /* Accessibility for links inside dialog box text */
 .jp-Dialog-content a {
   text-decoration: revert;
@@ -76,13 +53,6 @@ a:hover {
   color: revert;
 }
 
-/* Override Blueprint's _accessibility.scss styles */
-:focus {
-  outline: unset;
-  outline-offset: unset;
-  -moz-outline-radius: unset;
-}
-
 /* Styles for ui-components */
 .jp-Button {
   color: var(--jp-ui-font-color2);