Skip to content

Commit

Permalink
[exporter/signalfx] Keep container.cpu.time metric in the translations (
Browse files Browse the repository at this point in the history
open-telemetry#23403)

Do not drop `container.cpu.time` metric in the default translations so
it can be enabled in the `include_metrics` config option.

This is the only metric that is dropped in the translations. All other
metrics are being kept.
  • Loading branch information
dmitryax authored and fchikwekwe committed Jun 23, 2023
1 parent 6a1ad5c commit 4918bac
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 5 deletions.
15 changes: 15 additions & 0 deletions .chloggen/signalfx-exporter-dont-drop-container-cpu-time.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Use this changelog template to create an entry for release notes.
# If your change doesn't affect end users, such as a test fix or a tooling change,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: exporter/signalfx

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Do not drop container.cpu.time metric in the default translations so it can be enabled in the include_metrics config.

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [23403]
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ translation_rules:
k8s: true
container: true
- action: rename_metrics
- action: copy_metrics
mapping:
# kubeletstats container cpu needed for calculation below
container.cpu.time: sf_temp.container_cpu_utilization
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,8 @@ exclude_metrics:
- /^k8s\.(?i:(node)|(pod))\.filesystem\.capacity$/
- /^k8s\.(?i:(node)|(pod))\.filesystem\.usage$/
# matches (k8s.node|k8s.pod).cpu.time
- /^k8s\.(?i:(node)|(pod))\.cpu\.time$/
# matches (container|k8s.node|k8s.pod).cpu.utilization
# matches (container|k8s.node|k8s.pod).cpu...
- /^(?i:(container)|(k8s\.node)|(k8s\.pod))\.cpu\.time$/
- /^(?i:(container)|(k8s\.node)|(k8s\.pod))\.cpu\.utilization$/
# matches k8s.node.network.io and k8s.node.network.errors
Expand Down

0 comments on commit 4918bac

Please sign in to comment.