Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled exception when testing node/health during healthCheck #176

Closed
meyns opened this issue Mar 1, 2021 · 2 comments
Closed

Unhandled exception when testing node/health during healthCheck #176

meyns opened this issue Mar 1, 2021 · 2 comments
Labels

Comments

@meyns
Copy link

meyns commented Mar 1, 2021

Trying to run the healthCheck but apparently REST was not running fine yet and I got this exception:

2021-03-01T20:55:21.627Z info Testing http://localhost:3000/node/health
(node:3362394) UnhandledPromiseRejectionWarning: #
(node:3362394) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
(node:3362394) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
2021-03-01T20:55:21.643Z warn Rest http://localhost:3000/node/health is NOT up and running YET: {"statusCode":503,"statusMessage":"Service Unavailable","body":"{"status":{"apiNode":"down","db":"up"}}"}

@fboucquez fboucquez added the p3 label Mar 5, 2021
@fboucquez
Copy link
Owner

The health check should fail because Rest wasn't running. Is this happening?

The UnhandledPromiseRejectionWarning warning should be there.

@meyns
Copy link
Author

meyns commented Mar 5, 2021

The rest was not running ok, but imo the unhandled exception should be handled much cleaner. Especially if it is deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants