fix: Remove unused distutils import #176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distutils is deprecated in Python3.12 (ref: https://docs.python.org/3.10/library/distutils.html). Since it's not explicitly being used - not sure if it was crucial to the working of any util, perhaps we could use `packaging.version.Version` if it's still needed. ``` Python 3.12.4 (main, Jun 6 2024, 18:26:44) [GCC 13.2.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import sweetviz Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/home/gavin/Desktop/v1/maggie#2546/.venv/lib/python3.12/site-packages/sweetviz/__init__.py", line 15, in <module> from sweetviz.sv_public import analyze, compare, compare_intra File "/home/gavin/Desktop/v1/maggie#2546/.venv/lib/python3.12/site-packages/sweetviz/sv_public.py", line 4, in <module> import sweetviz.dataframe_report File "/home/gavin/Desktop/v1/maggie#2546/.venv/lib/python3.12/site-packages/sweetviz/dataframe_report.py", line 10, in <module> import sweetviz.series_analyzer as sa File "/home/gavin/Desktop/v1/maggie#2546/.venv/lib/python3.12/site-packages/sweetviz/series_analyzer.py", line 8, in <module> from distutils.version import LooseVersion ModuleNotFoundError: No module named 'distutils' ``` Distro: NixOS 24.05.3214.575f3027caa1 (Uakari) x86_64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distutils is deprecated in Python3.12 (ref: https://docs.python.org/3.10/library/distutils.html).
Since it's not explicitly being used - not sure if it was crucial to the working of any util, perhaps we could use
packaging.version.Versionif it's still needed.Distro: NixOS 24.05.3214.575f3027caa1 (Uakari) x86_64