Add unicode build targets and standardize string handling #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 11, 2014 19:44
…works nicely in unicode and non-unicode (avoid str255 except at the boundaries)
fb-datax
added a commit
that referenced
this pull request
Aug 12, 2014
Add unicode build targets and standardize string handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unicode build targets with settings that are compatible with Studio 5. Also standardized the string handling so that the xcomp only uses std::string and conversions happen at the boundaries of the component. In the long run it will make it easier to write logToTrace() messages, and it'll also make it easier to convert to Mac and Studio 5.