Skip to content

Commit

Permalink
fix: bump git-cliff for windows github integration support, remove wa…
Browse files Browse the repository at this point in the history
…rning for the same
  • Loading branch information
favna committed Mar 3, 2024
1 parent 0094cbe commit 5b96b11
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 44 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"compare-func": "^2.0.0",
"conventional-recommended-bump": "^9.0.0",
"execa": "^8.0.1",
"git-cliff": "^2.0.4",
"git-cliff": "^2.1.2",
"js-yaml": "^4.1.0",
"semver": "^7.6.0"
},
Expand Down
17 changes: 0 additions & 17 deletions src/lib/preflight-checks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@ import { packageCwd } from '#lib/constants';
import { createFile } from '#lib/createFile';
import { fileExists } from '#lib/fileExists';
import { logVerboseError } from '#lib/logger';
import { pressEnterToContinue } from '#lib/pressEnterToContinue';
import { doActionAndLog, getGitHubRepo, getGitHubToken, readJson } from '#lib/utils';
import { isNullishOrEmpty } from '@sapphire/utilities';
import type { Options } from 'commander';
import { platform } from 'node:os';
import { join } from 'node:path';

export async function preflightChecks(options: Options) {
Expand All @@ -28,21 +26,6 @@ export async function preflightChecks(options: Options) {

const githubRepo = getGitHubRepo(options);
if (!isNullishOrEmpty(githubRepo)) {
const os = platform();
if (os === 'win32') {
logVerboseError({
text: [
'GitHub integration is currently not functional on Windows due to limitations in git-cliff.',
'For more information, see https://github.com/orhun/git-cliff/issues/514',
'',
'This means that any GitHub integration markup in your cliff.toml such as "commit.github." will not work.'
],
verbose: options.verbose
});

await pressEnterToContinue();
}

const githubToken = getGitHubToken(options);

if (isNullishOrEmpty(githubToken)) {
Expand Down
26 changes: 0 additions & 26 deletions src/lib/pressEnterToContinue.ts

This file was deleted.

0 comments on commit 5b96b11

Please sign in to comment.