Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building source distribution #24

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Conversation

bdraco
Copy link

@bdraco bdraco commented Feb 21, 2023

@wbarnha
Copy link
Member

wbarnha commented Feb 21, 2023

Thanks again for the work!

@bdraco
Copy link
Author

bdraco commented Feb 21, 2023

% pip3 wheel faust-cchardet-2.1.18.tar.gz     
Processing ./faust-cchardet-2.1.18.tar.gz
  File was already downloaded /Users/bdraco/faust-cchardet-2.1.18.tar.gz
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: faust-cchardet
  Building wheel for faust-cchardet (pyproject.toml) ... done
  Created wheel for faust-cchardet: filename=faust_cchardet-2.1.18-cp310-cp310-macosx_13_0_arm64.whl size=124741 sha256=4b0bd75837d6a648482b81143feb00456c25472136b47cae36d67c825cb910c2
  Stored in directory: /Users/bdraco/Library/Caches/pip/wheels/fc/f2/51/265cd375b81fe95c5efe4d8ed699af709795b66974f04666ef
Successfully built faust-cchardet

[notice] A new release of pip available: 22.3.1 -> 23.0
[notice] To update, run: python3.10 -m pip install --upgrade pip

Looks good now.

Hopefully it behaves exactly the same way on the GH run

@bdraco bdraco marked this pull request as ready for review February 21, 2023 17:30
Copy link
Member

@wbarnha wbarnha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shame on me for not seeing this change sooner. I was wondering what the motivation for the initial change was, but I didn't think it'd break source builds.

@wbarnha wbarnha merged commit b8f0d3b into faust-streaming:master Feb 21, 2023
@bdraco
Copy link
Author

bdraco commented Feb 21, 2023

Thanks @wbarnha

Tested the following on macos and linux and 👍
pip3 wheel --no-binary faust-cchardet -vvvv faust-cchardet==2.1.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants