Reset shell before running a command in go#util#System #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure the commands still work when using a non-Bourne shell such as
fish or tcsh.
:help vim-doc recommends:
set shell='/bin/sh'
But this is not a great solution. This will mean that `:sh` will now invoke
`/bin/sh`, instead of `tcsh` or `fish`. It also means that things such as shell
aliases for `:!` will no longer work.
|
Thanks @Carpetsmoker. This sounds like good improvement. |
|
Thanks @fatih Maybe it's also a good idea to remove the part in the "TROUBLESHOOTING" section of the help file? This should no longer apply... |
|
@Carpetsmoker definitely. If you see something that needs to be changed/fixed feel free to open a PR. I'm usually fully loaded with PR's, fixes, my work, my personal time, etc.. So I have limited time. I'm more than happy for contributions 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure the commands still work when using a non-Bourne shell such as
fish or tcsh.
:help vim-doc recommends:
But this is not a great solution. This will mean that
:shwill now invoke/bin/sh, instead oftcshorfish. It also means that things such as shellaliases for
:!will no longer work.