-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverage overlay integration (vim-go-coverlay) #786
Conversation
Merge @t-yuki's https://github.com/t-yuki/vim-go-coverlay plugin into vim-go
Nice work! I was thinking in a couple of UX suggestions:
Thanks anyway ;-) |
Yeap, I'm going to remove
This is hard to do as I have to hack the sidebar. This is exactly the same as the HTML representation and I think it fits it better. So there will be only one opinionated way. Thanks for the feedback! |
Sounds cool anyway, thanks a lot! 👍 |
@@ -0,0 +1 @@ | |||
flavor 'fatih/vim-go', '~> 1.5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be removed since it means This test depends on external plugin vim-go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. Btw I've changed the source code a lot and renamed the internal functions too. They will not work and probably will be broken. But I'm going to work on tests soon.
7c4157b
to
9fb2551
Compare
9fb2551
to
0eff026
Compare
I'm merging this. Tested it extensively and should be working very well. I've disabled supporting multiple files as it's not scalable. I prefer we go simple, let first be good at supporting the current buffer, later we can use the cached result for other buffers in the future. Please open an issue if you see bugs! Thanks. |
This PR includes #785, mainly @t-yuki's excellent https://github.com/t-yuki/vim-go-coverlay plugin with additional improvements and integrations into the vim-go code base. Changes are:
:GoCoverage
does highlights the current source code instead of opening a browser. When called again it clears the highlighting.:CoCoverageBrowser
opens the html annotated coverage result (previous:GoCoverage
Thanks for @t-yuki excellent initial work!
Here is demo: