plugin: install tools with -mod=mod #3449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Install tools with -mod=mod instead of -mod=readonly to avoid problem when some dependency of the tool being updated needs a newer version of Go than some other dependency while also still satisfying the original motivation for using the -mod flag (i.e. installing tools even when GOFLAGSS=-mod=vendor). Fixes fatih#3446
bhcleek
force-pushed
the
update-binaries/fix
branch
from
16440d8
to
48cea0c
Compare
bhcleek
force-pushed
the
update-binaries/fix
branch
from
48cea0c
to
a30bd4e
Compare
bhcleek
added a commit
that referenced
this pull request
Sep 3, 2022
basvdlei
added a commit
to basvdlei/go-toolbox
that referenced
this pull request
Sep 10, 2022
Cherry-pick the work-around: fatih/vim-go#3449
mjolk
pushed a commit
to mjolk/vim-go
that referenced
this pull request
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install tools with -mod=mod instead of -mod=readonly to avoid problem
when some dependency of the tool being updated needs a newer version of
Go than some other dependency while also still satisfying the original
motivation for using the -mod flag (i.e. installing tools even when
GOFLAGSS=-mod=vendor).
Fixes #3446