syntax: remove the numeric error matches #3404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the numeric error matches, because the regular expression patterns are incredibly difficult to get right and will likely never be fully correct. They are also of limited value given the correct highlighting of the valid numeric matches. Additionally, the errors are not flagged by `gopls` w/ the diagnostic text properties and building also identifies any problems.
bhcleek
force-pushed
the
syntax/remove-numeric-error
branch
from
6db2fcb
to
02e4101
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the numeric error matches, because the regular expression
patterns are incredibly difficult to get right and will likely never be
fully correct. They are also of limited value given the correct
highlighting of the valid numeric matches. Additionally, the errors are
not flagged by
goplsw/ the diagnostic text properties and buildingalso identifies any problems.