correct and extend use of g:go_diagnostics_level #3119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the diagnostics level to determine whether to store the diagnostics with the buffer and the diagnostic highlight options to determine whether to highlight the relevent text. This will allow users to toggle highlighting to affect whether text is highlighted and adjust the level to determine whether there are any diagnostics stored at all.
bhcleek
force-pushed
the
diagnostics/highlighting-correctly
branch
from
352ad0b
to
a390813
Compare
bhcleek
added a commit
that referenced
this pull request
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsp: use diagnostic options properly
Use the diagnostics level to determine whether to store the diagnostics
with the buffer and the diagnostic highlight options to determine
whether to highlight the relevent text.
This will allow users to toggle highlighting to affect whether text is
highlighted and adjust the level to determine whether there are any
diagnostics stored at all.
lsp: ignore diagnostics that do not satisfy g:go_diagnostics_level