lsp: implement fillstruct #3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhcleek
force-pushed
the
lsp/fillstruct
branch
from
b00e272
to
c6585cc
Compare
Create and call a new function that applies the documentChanges property of a WorkspaceEdit message.
Add a new option, g:go_fill_struct_mode, to allow gopls to be used to satisfy :GoFillStruct Fix a small bug with debugging gopls; make sure the timer starts when the queue's first item is added instead of starting only when a second message is added to the queue. Closes fatih#2940
bhcleek
force-pushed
the
lsp/fillstruct
branch
from
c6585cc
to
68020c9
Compare
bhcleek
added a commit
that referenced
this pull request
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsp: refactor applying document changes
Create and call a new function that applies the documentChanges property
of a WorkspaceEdit message.
fillstruct: add an option to satisfy fill struct with gopls
Add a new option, g:go_fill_struct_mode, to allow gopls to be used to
satisfy :GoFillStruct
Fix a small bug with debugging gopls; make sure the timer starts when
the queue's first item is added instead of starting only when a second
message is added to the queue.
Closes #2940
fillstruct: add tests for gopls mode