debug: make rpc commands async so Vim will be responsive while waiting for delve response #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor debugger rpc response handling of execution commands (e.g. continue, next, step) to be async by default. By using promises, some other rpc reponse are awaited inline. Add only GoDebugContinue and GoDebugStop after GoDebugStart or GoDebugTest. The rest of the commands, (e.g. GoDebugNext, GoDebugStep, etc.) are added after continuing.
bhcleek
changed the title
bhcleek
added a commit
that referenced
this pull request
Jul 4, 2020
bhcleek
added a commit
to bhcleek/vim-go
that referenced
this pull request
Jul 6, 2020
Update documentation to reflect changes made in fatih#2948 that changed when debugging commands and mappings are made available.
bhcleek
added a commit
to bhcleek/vim-go
that referenced
this pull request
Jul 6, 2020
Update documentation to reflect changes made in fatih#2948 that changed when debugging commands and mappings are made available.
bhcleek
added a commit
that referenced
this pull request
Jul 6, 2020
doc: update documentation for #2948
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
promise: teach promises to handle exceptions
debug: refactor to make rpc response handling async
Refactor debugger rpc response handling of execution commands (e.g.
continue, next, step) to be async by default. By using promises, some
other rpc reponse are awaited inline.
Add only GoDebugContinue and GoDebugStop after GoDebugStart or
GoDebugTest. The rest of the commands, (e.g. GoDebugNext, GoDebugStep,
etc.) are added after continuing.
@MatthewMarkgraaff this should resolve the responsiveness issue you mentioned in #2915.