chore: godoc popup border style

[zhengkai]

godoc popup cames from g:go_doc_popup_window

what I changed:

1. beautify popup border style if utf-8 supported
2. add variable g:go_doc_popup_border to support custome border style

default style (original):

default style if utf-8 supported:

bounded style with let g:go_doc_popup_border = ['─', '│', '─', '│', '╭', '╮', '╯', '╰'] :

[bhcleek]

Is there any reason to add the new option to make the border customizable?

[zhengkai]

Sorry, I don't know how to change it in other way ? I saw the original style is hard coded

vim-go/autoload/go/doc.vim

Line 66 in 9fa8d1e

\ 'borderchars': ['-','|','-','|','+','+','+','+'],

Maybe someone like rounded or other style ? so he/she can changed it simply by new option ?

[bhcleek]

I think that we can do with out g:go_doc_popup_border and just use borderchars as you've defined it.

i.e.

let borderchars = ['-', '|', '-', '|', '+', '+', '+', '+']
if &encoding == "utf-8"
   let borderchars = ['─', '│', '─', '│', '┌', '┐', '┘', '└']
endif

is sufficient; I don't see a reason to support a custom border style with g:go_doc_popup_border.

[zhengkai]

From my perspective, I like as many options as possible. They don’t waste any memory and CPU. The only drawback is that they need to be written. But I have already done it.

Not everyone needs it, but someone needs it.

Maybe we can look at the opinions of others. If all of you feel unnecessary, you can remove it ( or by me ? )

[bhcleek]

Yes, please remove the new option. More options is unnecessary overhead and should only be added when it adds clear value, because every option adds complexity. Constraints are useful, and I only have so much time to debug, triage issues, and maintain vim-go.