Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: handle more golangci-lint output #2720

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

bhcleek
Copy link
Collaborator

@bhcleek bhcleek commented Feb 12, 2020

Handle problems reported by golangci-lint that don't have a file
location at all.

Handle error reported by golangci-lint that don't have a column number.

Handle problems reported by golangci-lint that don't have a file
location at all.

Handle error reported by golangci-lint that don't have a column number.
@bhcleek
Copy link
Collaborator Author

bhcleek commented Feb 12, 2020

@Integralist this at least stop hiding some of the information that was being overwritten for you in some cases. It's not perfect, but it's an improvement.

re: #2700 (comment)

@bhcleek bhcleek merged commit 5a427b9 into fatih:master Feb 12, 2020
@bhcleek bhcleek deleted the lint/golangci-lint/moar-problems branch February 12, 2020 02:49
bhcleek added a commit that referenced this pull request Feb 12, 2020
@bhcleek bhcleek added this to the vim-go 1.23 milestone Feb 20, 2020
@bhcleek bhcleek mentioned this pull request Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant