Set shell to cmd.exe with flag /C on Windows

[drichardson]

If shell was set to pwsh, then vim-go would fail when creating a new file from a template.

This PR sets the shell to cmd.exe with the /C flag, which is how stock vim on Windows is configured.

Fixes #2712.

[bhcleek]

Thank you for the PR. Before merging this, I wonder if there's a way to handle the situation you describe without changing the shell.

Also, we'll need to restore the previous option value once the command is executed if we stick with this approach.

[drichardson]

Thank you for the PR. Before merging this, I wonder if there's a way to handle the situation you describe without changing the shell.

I was wondering the same thing, and I think it would be better (in this case) to execute the command like a unix exec would (not system, aka no shell involved). However, that has a bigger chance of breaking things (and I'm not even sure an exec type facility exists in vimscript). I thought to be safe it would be better to have a consistent shell set for windows (the same way it is done for systems that have /bin/sh).

Also, we'll need to restore the previous option value once the command is executed if we stick with this approach.

That is already done by the finally block below the code I wrote.

[bhcleek]

LGTM

[bhcleek]

I was wondering the same thing, and I think it would be better (in this case) to execute the command like a unix exec would (not system, aka no shell involved). However, that has a bigger chance of breaking things (and I'm not even sure an exec type facility exists in vimscript).

FWIW, I'm not aware of any way to do this with VimL or as an ex command.

But my question was really about wondering what the problem you've experienced is and whether there's a way to avoid changing the shell used by vim-go on Windows.