try to use relative import paths if necessary #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teach go#debug#Start, go#lint#Vet, and go#lint#ErrCheck to work in null modules. Refactor go#package#ImportPath to delegate to go#package#FromPath. Teach go#package#FromPath to return a relative package path when in a null module if possible. When the package is not within the current working directory, -2 will still be returned. This allows go#debug#Start, go#lint#Vet, and go#lint#Errcheck to work in null modules. Add a test for go#debug#Start using a relative path in a null module. Correct documentation for :GoDebugStart. Fix `:GoVet` with arguments so that it will run for the package that contains the current buffer instead of just using whatever the current working directory is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teach go#debug#Start, go#lint#Vet, and go#lint#ErrCheck to work in null
modules.
Refactor go#package#ImportPath to delegate to go#package#FromPath.
Teach go#package#FromPath to return a relative package path when in a
null module if possible. When the package is not within the current
working directory, -2 will still be returned. This allows
go#debug#Start, go#lint#Vet, and go#lint#Errcheck to work in null
modules.
Add a test for go#debug#Start using a relative path in a null module.
Correct documentation for :GoDebugStart.
Fix
:GoVetwith arguments so that it will run for the package thatcontains the current buffer instead of just using whatever the current
working directory is.