lsp: adjust to gopls changes #2291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the handling of gopls completion responses to account for recent changes where they refactored how completion candidates are formed. Each candidate has a start position (often _before_ the cursor position) and the character within the line where the matches begin. Previously, the cursor position could be used, because candidate returned from gopls only included the text after the cursor position.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the handling of gopls completion responses to account for recent
changes where they refactored how completion candidates are formed. Each
candidate has a start position (often before the cursor position) and
the character within the line where the matches begin. Previously, the
cursor position could be used, because candidate returned from gopls
only included the text after the cursor position.