debug: allow debugging outside GOPATH without a go.mod #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not try to determine the package name being debugged. Delve supports debugging and testing without specifying a package name; vim-go should, too. One of the things that this makes easier is debugging code that is neither in GOPATH nor in a module. Remove unnecessary is_test key from the state dictionary. Remove code that set the current directory when debugging tests. Because delve is started as an async job, its cwd will be set to the directory of the buffer from which debugging is started, anyway. Using `lcd` to set the buffer local directory is just another thing to keep track of and it doesn't seem to have any real benefit. Update documentation to explain how relative paths work for `:GoDebug` and `:GoDebugTest`. Refactor go#package#FromPath so that it returns -2 when the package is neither in GOPATH nor in the current module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not try to determine the package name being debugged. Delve supports
debugging and testing without specifying a package name; vim-go should,
too. One of the things that this makes easier is debugging code that is
neither in GOPATH nor in a module.
Remove unnecessary is_test key from the state dictionary.
Remove code that set the current directory when debugging tests. Because
delve is started as an async job, its cwd will be set to the directory
of the buffer from which debugging is started, anyway. Using
lcdtoset the buffer local directory is just another thing to keep track of
and it doesn't seem to have any real benefit.
Update documentation to explain how relative paths work for
:GoDebugand
:GoDebugTest.Refactor go#package#FromPath so that it returns -2 when the package is
neither in GOPATH nor in the current module.