set GO111MODULE=off when installing tools #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhcleek
force-pushed
the
install-module-mode
branch
2 times, most recently
from
1d1017b
to
accdb09
Compare
Set GO111MODULE=off when installing tools, because some tools' (gometalinter and golangci-lint at this writing) won't install in module mode. Add a new function, go#util#SetEnv, to make it easy to set and restore environment variables correctly. Fixes fatih#2248
bhcleek
force-pushed
the
install-module-mode
branch
from
accdb09
to
1237fa0
Compare
bhcleek
added a commit
that referenced
this pull request
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set GO111MODULE=off when installing tools, because some tools'
(gometalinter and golangci-lint at this writing) won't install in module
mode.
Add a new function, go#util#SetEnv, to make it easy to set and restore
environment variables correctly.
Fixes #2248