clear buffer-local autocmds correctly #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clear buffer-local autocmds correctly without clearing the same autocmds for other buffers. As an example of why this should be done: prior to this change, opening a window for each of two separate files and then running `:GoCoverage` in each would highlight coverage as expected. Loading a third buffer into one of the windows would clear the highlighting in that window and would _also_ remove the other window's buffer-local autocmd event to clear its coverage highlighting. Loading a different buffer into the other window would unexpectedly _keep_ the highlighting, because the autocmd event configuration was removed when the third buffer was loaded into its window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear buffer-local autocmds correctly without clearing the same autocmds
for other buffers.
As an example of why this should be done: prior to this change, opening
a window for each of two separate files and then running
:GoCoveragein each would highlight coverage as expected. Loading a third buffer
into one of the windows would clear the highlighting in that window and
would also remove the other window's buffer-local autocmd event to
clear its coverage highlighting. Loading a different buffer into the
other window would unexpectedly keep the highlighting, because the
autocmd event configuration was removed when the third buffer was loaded
into its window.