Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ToggleSameIds that calls SameIds with no args #2086

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

110y
Copy link
Contributor

@110y 110y commented Dec 7, 2018

ToggleSameIds is causing an error that says Not enough arguments for function: go#guru#SameIds.
So, I fixed it.

I'm glad if someone reviews this, thanks.

@110y
Copy link
Contributor Author

110y commented Dec 7, 2018

CI failed with this error:

--- FAIL Test_goimports (0.022243s)
        function Test_goimports line 13: Expected 'package main\n\nimport (\n\t"fmt"\n\n\tlogging "gh.com/gi/foo-logging"\n)\n\nfunc Foo(log *logging.TestLogger) {\n\tlog.Debug("vim-go")\n}\n\nfunc main() {\n\tfmt.Println("vim-go")\n}' but got 'package main\n\nimport (\n\t"fmt"\n)\n\nfunc Foo(log *logging.TestLogger) {\n\tlog.Debug("vim-go")\n}\n\nfunc main() {\n\tfmt.Println("vim-go")\n}'

But, I think this error was caused by recently goimports update including breaking changes and this pull request isn't related.

@bhcleek
Copy link
Collaborator

bhcleek commented Dec 7, 2018

thank you

@bhcleek bhcleek merged commit 75df082 into fatih:master Dec 7, 2018
bhcleek added a commit that referenced this pull request Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants