Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display statuslines consistently #1937

Merged
merged 1 commit into from
Sep 2, 2018

Conversation

bhcleek
Copy link
Collaborator

@bhcleek bhcleek commented Sep 2, 2018

  • Do not update the status line when guru commands are run via
    autocommands.
  • Update the status line when gocode is run via :GoInfo.

* Do not update the status line when guru commands are run via
  autocommands.
* Update the status line when gocode is run via :GoInfo.
@fatih
Copy link
Owner

fatih commented Sep 2, 2018

I still think we should remove the codecov/patch check. It shows things in red where they shouldn't be :/ I think we tweaked it once?

@bhcleek
Copy link
Collaborator Author

bhcleek commented Sep 2, 2018

This handles two UX issues:

  1. When running a long-running command (e.g. :GoReferrers) with g:go_auto_sameids=1 or g:go_auto_type_info=1 , the user would see the statusline updated to say the long-running command was started, but then quickly see the statusline updated with info that the command CursorHold autocmd completed successfully, hiding the started statusline update for the long-running command.
  2. Sets the statusline for :GoInfo regardless of the value of g:go_info_mode.

@fatih
Copy link
Owner

fatih commented Sep 2, 2018

lgtm for the PR 👍

@bhcleek bhcleek merged commit 0e7bd40 into fatih:master Sep 2, 2018
@bhcleek bhcleek deleted the gocode-guru-statuslines branch September 2, 2018 14:40
bhcleek added a commit that referenced this pull request Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants