guru.vim: defer ImportPath check #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the k8s.io/kubernetes repo, vendor/k8s.io/{api,apiservers} etc. are
symbolic links to corresponding dir staging/src/k8s.io/{api,apiservers}.
vendor/k8s.io/apiserver -> ../../staging/src/k8s.io/apiserver
ImportPath detection for files under these staging directories will fail
because '%:p:h' does not match any items of 'go list'
For large projects like k8s, users tend to set the g:go_guru_scope
variable. The change is mainly a workaround trying to improve
experience so that those not worked before will work now and it will not
affect existing usage.
|
Hi, the change should be safe to merge. It just moves the integrity check to where it was actually needed. The check failure on test coverage was also not newly caused by the diff of the change. |
|
Thank you. |
bhcleek
added a commit
that referenced
this pull request
May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the k8s.io/kubernetes repo, vendor/k8s.io/{api,apiservers} etc. are
symbolic links to corresponding dir staging/src/k8s.io/{api,apiservers}.
ImportPath detection for files under these staging directories will fail
because '%:p:h' does not match any items of 'go list'
For large projects like k8s, users tend to set the g:go_guru_scope
variable. The change is mainly a workaround trying to improve
experience so that those not worked before will work now and it will not
affect existing usage.