Add build tags 'g:go_build_tags' for gogetdoc #1702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1702 +/- ##
==========================================
- Coverage 19.73% 19.72% -0.01%
==========================================
Files 57 57
Lines 4748 4750 +2
==========================================
Hits 937 937
- Misses 3811 3813 +2
Continue to review full report at Codecov.
|
arp242
reviewed
Mar 5, 2018
| @@ -148,6 +148,11 @@ function! s:gogetdoc(json) abort | |||
| let pos = shellescape(fname.':#'.offset) | |||
|
|
|||
| let cmd += ["-pos", pos] | |||
|
|
|||
| if exists('g:go_build_tags') | |||
| let cmd += ["-tags", get(g:, 'go_build_tags')] | |||
There was a problem hiding this comment.
Did you test that this will work with multiple build tags? I'm, not 100% sure, but I think you need to do:
['-tags', go#util#Shellescape(get(g:, 'go_build_tags'))]
So that g:go_build_tags='foo bar' will be:
gogetdoc -tags 'foo bar' someident
Instead of:
gogetdoc -tags foo bar someIdent
There was a problem hiding this comment.
Yes, you are right, sorry for that changes. I had read the doc about build constraints again.
And I saw your commit #1705. That's much better. Thanks for your advice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify build tags for
gogetdoccommand, with theg:go_build_tagssetting.