cmd: go 1.10 maintains a build cache now

[fatih]

We don't need this hack anymore to speed up building.

[codecov-io]

Codecov Report

Merging #1701 into master will increase coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1701      +/-   ##
==========================================
+ Coverage   19.75%   20.09%   +0.33%     
==========================================
  Files          57       57              
  Lines        4738     4758      +20     
==========================================
+ Hits          936      956      +20     
  Misses       3802     3802

Flag	Coverage Δ
#nvim	15.02% <ø> (-0.07%)	⬇️
#vim74	17.23% <ø> (-0.08%)	⬇️
#vim80	19.02% <ø> (+0.34%)	⬆️

Impacted Files	Coverage Δ
autoload/go/cmd.vim	5.73% <ø> (ø)	⬆️
autoload/go/lint.vim	61.61% <0%> (+4.31%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaef6f7...2447029. Read the comment docs.

[bhcleek]

Do we want to remove this already? For how long should we support optimizations for past releases of go?

[fatih]

I usually trying to keep up with latest. It helps the community to upgrade to the latest version and also makes the life easier for us (like how Apple encourages people to upgrade to the latest iOS version).

Of course not everyone can upgrade their Go version. We can check the version, like how we do it in plugin/go.vim but that will add additional latency and we need to add caching to mitigate it. I say let's merge this as this is added recently already.

[arp242]

But it's not like go build -i does any harm, right?

Either way, I think it's fine to both merge it and keep as-is, but I do think it would be a good idea to add an entry in the BACKWARDS INCOMPATIBILITIES section of the ChangeLog.

[bhcleek]

Lgtm

[fatih]

But it's not like go build -i does any harm, right?

yeah definitely, but :GoBuild in its plan form implies that it only runs go build. But we change the semantics. Not that we didn't do it for other commands or whatsoever. Just with 1.10 this is not required anymore. Keeping things like this bloats the codebase with time because people tend to forget things in the long term. Merging this and adding an entry under BACKWARDS INCOMPATIBILITIES