respect a changed g:go_test_show_name #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Respect the current value of g:go_test_show_name on :GoTest runs after the first one by invalidating the cached errorformat value when the g:go_test_show_name value is not the same as it was when the errorformat value was last cached. Only show the test name for failed tests instead of including the '--- FAIL: ' prefix and the duration suffix when g:go_test_show_name=1. Resolve a TODO item in the test errorformat so that the regular expression used for test errorformat values is more precise. Remove a bit of testing code that is no longer needed; it was probably rendered obsolete with some recent changes to how the errorformat value is created.
Codecov Report
@@ Coverage Diff @@
## master #1641 +/- ##
=========================================
+ Coverage 17.77% 19.3% +1.52%
=========================================
Files 57 53 -4
Lines 4770 4159 -611
=========================================
- Hits 848 803 -45
+ Misses 3922 3356 -566
Continue to review full report at Codecov.
|
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respect the current value of g:go_test_show_name on :GoTest runs after
the first one by invalidating the cached errorformat value when the
g:go_test_show_name value is not the same as it was when the errorformat
value was last cached.
Only show the test name for failed tests instead of including the
'--- FAIL: ' prefix and the duration suffix when g:go_test_show_name=1.
Resolve a TODO item in the test errorformat so that the regular
expression used for test errorformat values is more precise.
Remove a bit of testing code that is no longer needed; it was probably
rendered obsolete with some recent changes to how the errorformat value
is created.