Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepend test name to test errors #1578

Merged
merged 2 commits into from
Nov 23, 2017
Merged

Conversation

bhcleek
Copy link
Collaborator

@bhcleek bhcleek commented Nov 21, 2017

Add an option to prepend the test name to test errors and log messages.

Fixes #1262

@bhcleek bhcleek force-pushed the prepend-test-names branch 3 times, most recently from 0292e42 to 945701a Compare November 21, 2017 06:05
bhcleek and others added 2 commits November 23, 2017 15:13
Add an option to prepend the test name to test errors and log messages.

Fixes fatih#1262
@arp242
Copy link
Contributor

arp242 commented Nov 23, 2017

Works well in my testing

@arp242 arp242 merged commit 432dc7f into fatih:master Nov 23, 2017
@arp242
Copy link
Contributor

arp242 commented Nov 23, 2017

We could maybe consider enabling this by default by the way. In fact, I'm not even sure we need to have an option to disable it.

@bhcleek
Copy link
Collaborator Author

bhcleek commented Nov 23, 2017

I considered it, but often times the test name is long enough that it distracts from the message.

@fatih
Copy link
Owner

fatih commented Nov 29, 2017

I really liked this new addition 👍

@bhcleek bhcleek deleted the prepend-test-names branch November 29, 2017 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants