Various fixes for paths and GOPATH with spaces #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example: `~/go/src/space path/a/a.go` Tested with both `godef` and `guru`. Continuation of #1288
Test setup: export GOPATH="/home/martin/go path/go" export PATH="/usr/local/sbin:/usr/local/bin:/usr/bin" vim "/home/martin/go path/go/src/a/a.go" There may be other places as well; this is just the result from a quick test with my personal default settings. Since there are a lot of if/else branches relating to jobs etc. it's kind of hard to test everything without a full audit. It's perhaps a good idea to refactor some of this in a slightly more structured way at some point: instead of passing strings we should pass a list which is always escaped (like `os.Exec()`, Python's subprocess, etc.) This should fix #1288
|
Thanks @Carpetsmoker much appreciated 👍
We do it already for jobs, but not for old style system call. For those for some of the newly refactored code (Such as lint.vim (gometalinter) I'm converting the list to a string before passing it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1288, as well as a number of other commands.
There may be other places as well; this is just the result from a quick test
with my personal default settings. Since there are a lot of if/else branches
relating to jobs etc. it's kind of hard to test everything without a full audit.
It's perhaps a good idea to refactor some of this in a slightly more structured
way at some point: instead of passing strings we should pass a list which is
always escaped (like
os.Exec(), Python's subprocess, etc.)