coverage.vim: pass along arguments to coverage_job #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
refs #1196 |
fatih
reviewed
Jun 8, 2017
| @@ -46,7 +46,7 @@ function! go#coverage#Buffer(bang, ...) abort | |||
|
|
|||
| if go#util#has_job() | |||
| call s:coverage_job({ | |||
| \ 'cmd': ['go', 'test', '-coverprofile', l:tmpname], | |||
| \ 'cmd': ['go', 'test', '-coverprofile', l:tmpname] + a:000, | |||
There was a problem hiding this comment.
What if I don't pass anything? What is the value of a:000? How does coverage look like for a single function?
There was a problem hiding this comment.
This is the first vimscript I've written.
a:000 is '[]' by default:
:breakadd func 24 go#coverage#Buffer
:debug GoCoverage
>cont
Breakpoint in "go#coverage#Buffer" line 24
function go#coverage#Buffer
line 24: if go#util#has_job()
>echo a:000
[]
>n
function go#coverage#Buffer
line 25: call s:coverage_job({ 'cmd': ['go', 'test', '-coverprofile', l:tmpname] + a:000, 'custom_cb': function('s:coverage_callback', [l:tmpname]), 'bang': a:bang, })
>echo ['go', 'test', '-coverprofile', l:tmpname] + a:000
['go', 'test', '-coverprofile', '/var/folders/3j/pjbjsn3x5vjf20fl1qb_q8z00000gn/T/vuMXJDi/78']
>echo ['go', 'test', '-coverprofile', l:tmpname]
['go', 'test', '-coverprofile', '/var/folders/3j/pjbjsn3x5vjf20fl1qb_q8z00000gn/T/vuMXJDi/78']
>echo a:000
[]
>
There was a problem hiding this comment.
Thanks, and how does it look like inside Vim ? Can you add a screenshot?
There was a problem hiding this comment.
Visually it looks the same as :GoCoverage -- it will instead only show lines covered by the particular test(s) run.
|
Thanks @tmc , looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows things like
:GoCoverage -run TestSpecificwhich allows you to see the exact coverage for a test/subtest.It looks like this was the intent but may have been missed in dc80733